Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread Tom Lane
"David G. Johnston" writes: > On Mon, Mar 19, 2018 at 8:33 AM, Tom Lane wrote: > ​Another one that seems to fall into the "fairly large-scale work" would be > the: > ​ERROR: more than one row returned by a subquery used as an expression > (that's it, nothing else prints in psql when I run the of

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread David G. Johnston
On Mon, Mar 19, 2018 at 8:33 AM, Tom Lane wrote: > "David G. Johnston" writes: > > Frankly, I'm not seeing "invalid constant regular expressions" as being a > > large scale problem - but I'll agree that having the error include the > > actual literal being parsed as a RegEx should be done. > > A

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread David G. Johnston
On Mon, Mar 19, 2018 at 9:11 AM, Tom Lane wrote: > "David G. Johnston" writes: > > On Mon, Mar 19, 2018 at 8:33 AM, Tom Lane wrote: > >> But I wonder if we wouldn't be better off to put the regex into a > >> detail line, ie > >> errmsg("invalid regular expression: %s", ...), > >>

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread Tom Lane
"David G. Johnston" writes: > On Mon, Mar 19, 2018 at 8:33 AM, Tom Lane wrote: >> But I wonder if we wouldn't be better off to put the regex into a >> detail line, ie >> errmsg("invalid regular expression: %s", ...), >> errdetail("Regular expression is \"%s\".", ...), >

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread David G. Johnston
On Mon, Mar 19, 2018 at 8:33 AM, Tom Lane wrote: > "David G. Johnston" writes: > > Frankly, I'm not seeing "invalid constant regular expressions" as being a > > large scale problem - but I'll agree that having the error include the > > actual literal being parsed as a RegEx should be done. > > A

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread Tom Lane
"David G. Johnston" writes: > Frankly, I'm not seeing "invalid constant regular expressions" as being a > large scale problem - but I'll agree that having the error include the > actual literal being parsed as a RegEx should be done. Agreed. Doing anything about the other stuff discussed in this

Re: Problems with Error Messages wrt Domains, Checks

2018-03-19 Thread David G. Johnston
On Sat, Mar 17, 2018 at 12:54 PM, john frazer wrote: > > -- Forwarded message -- > From: john frazer > Date: Sat, Mar 17, 2018 at 6:28 PM > Subject: Re: Problems with Error Messages wrt Domains, Checks > To: "David G. Johnston" > > > As

Re: Problems with Error Messages wrt Domains, Checks

2018-03-17 Thread David G. Johnston
On Sat, Mar 17, 2018 at 6:14 AM, john frazer wrote: > Today I realized a number of points where PostgreSQL (v10.3) is rather > lackluster and sparse in its error messages. > > ​You may find the following thread and its predecessors enlightening. https://www.postgresql.org/message-id/CAD3a31WR8X1