Re: Prevent pg_basebackup running as root

2020-02-06 Thread Andres Freund
Hi, On 2020-02-01 18:34:33 +0900, Michael Paquier wrote: > Seeing nothing, committed v2. For reference: As a consequence of the discussion starting at https://www.postgresql.org/message-id/20200205172259.GW3195%40tamriel.snowman.net this patch has been reverted, at least for now. Greetings, And

Re: Prevent pg_basebackup running as root

2020-02-02 Thread Ian Barwick
On 2020/02/01 18:34, Michael Paquier wrote: On Thu, Jan 30, 2020 at 04:00:40PM +0900, Michael Paquier wrote: Anyway, your patch looks like a good idea to me, so let's see if others have opinions or objections about it. Seeing nothing, committed v2. Thanks! Regards Ian Barwick -- Ian Bar

Re: Prevent pg_basebackup running as root

2020-02-01 Thread Michael Paquier
On Thu, Jan 30, 2020 at 04:00:40PM +0900, Michael Paquier wrote: > Anyway, your patch looks like a good idea to me, so let's see if > others have opinions or objections about it. Seeing nothing, committed v2. -- Michael signature.asc Description: PGP signature

Re: Prevent pg_basebackup running as root

2020-01-29 Thread Michael Paquier
On Thu, Jan 30, 2020 at 03:38:54PM +0900, Ian Barwick wrote: > 2020年1月30日(木) 14:57 Michael Paquier : I have never noticed that your client was configured in Japanese :) > I think we can skip the second sentence altogether. It'd be theoretically > easy enough to up with some combination of group p

Re: Prevent pg_basebackup running as root

2020-01-29 Thread Ian Barwick
2020年1月30日(木) 14:57 Michael Paquier : > > On Thu, Jan 30, 2020 at 02:29:06PM +0900, Ian Barwick wrote: > > I can't think of any practical reason why pg_basebackup would ever need to > > be run as root; we disallow that for initdb, pg_ctl and pg_upgrade, so it > > seems reasonable to do the same for

Re: Prevent pg_basebackup running as root

2020-01-29 Thread Michael Paquier
On Thu, Jan 30, 2020 at 02:29:06PM +0900, Ian Barwick wrote: > I can't think of any practical reason why pg_basebackup would ever need to > be run as root; we disallow that for initdb, pg_ctl and pg_upgrade, so it > seems reasonable to do the same for pg_basebackup. Trivial patch attached, > which