Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
> > >I am thinking so simple number should be good enough. We can require > >equality - Just I need a signal so some is wrong - better than Postgres > >crash. > > It'd cause constant conflicts and / or we would regularly forget updating > it. It's not that trivial to determine what influences ABI c

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Tom Lane
Andres Freund writes: >> I am thinking so simple number should be good enough. We can require >> equality - Just I need a signal so some is wrong - better than Postgres >> crash. > It'd cause constant conflicts and / or we would regularly forget updating it. > It's not that trivial to determine

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
On October 8, 2018 10:29:56 AM PDT, Pavel Stehule wrote: >po 8. 10. 2018 v 19:24 odesílatel Andres Freund >napsal: > >> >> >> On October 8, 2018 10:16:54 AM PDT, Pavel Stehule > >> wrote: >> >po 8. 10. 2018 v 17:59 odesílatel Andres Freund >> >napsal: >> > >> >> Hi, >> >> >> >> On 2018-10-08

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 19:24 odesílatel Andres Freund napsal: > > > On October 8, 2018 10:16:54 AM PDT, Pavel Stehule > wrote: > >po 8. 10. 2018 v 17:59 odesílatel Andres Freund > >napsal: > > > >> Hi, > >> > >> On 2018-10-08 11:43:42 -0400, Tom Lane wrote: > >> > Andres Freund writes: > >> > > On O

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
On October 8, 2018 10:16:54 AM PDT, Pavel Stehule wrote: >po 8. 10. 2018 v 17:59 odesílatel Andres Freund >napsal: > >> Hi, >> >> On 2018-10-08 11:43:42 -0400, Tom Lane wrote: >> > Andres Freund writes: >> > > On October 8, 2018 8:03:56 AM PDT, Tom Lane >wrote: >> > >> A look in guc.c shows

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 17:59 odesílatel Andres Freund napsal: > Hi, > > On 2018-10-08 11:43:42 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: > > >> A look in guc.c shows that jit defaults to "on" whether or not JIT is > > >> enabled at compi

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
Hi, On 2018-10-08 11:43:42 -0400, Tom Lane wrote: > Andres Freund writes: > > On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: > >> A look in guc.c shows that jit defaults to "on" whether or not JIT is > >> enabled at compile time. > >> This seems, at best, rather user-unfriendly. > >> And it

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Tom Lane
Andres Freund writes: > On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: >> A look in guc.c shows that jit defaults to "on" whether or not JIT is >> enabled at compile time. >> This seems, at best, rather user-unfriendly. >> And it's not like our conventions for other compile-option-affected >

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 17:22 odesílatel Andres Freund napsal: > > > On October 8, 2018 8:16:06 AM PDT, Pavel Stehule > wrote: > >po 8. 10. 2018 v 17:10 odesílatel Andres Freund > >napsal: > > > >> > >> > >> On October 8, 2018 8:03:56 AM PDT, Tom Lane > >wrote: > >> >Andres Freund writes: > >> >> Wh

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
On October 8, 2018 8:16:06 AM PDT, Pavel Stehule wrote: >po 8. 10. 2018 v 17:10 odesílatel Andres Freund >napsal: > >> >> >> On October 8, 2018 8:03:56 AM PDT, Tom Lane >wrote: >> >Andres Freund writes: >> >> Where is the jit=on coming from? Config from before it was turned >> >off? >> > >>

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 17:10 odesílatel Andres Freund napsal: > > > On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: > >Andres Freund writes: > >> Where is the jit=on coming from? Config from before it was turned > >off? > > > >A look in guc.c shows that jit defaults to "on" whether or not JIT is >

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
On October 8, 2018 8:10:45 AM PDT, Andres Freund wrote: > > >On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: >> This seems, at best, rather user-unfriendly. >>And it's not like our conventions for other compile-option-affected >>GUCs, eg the SSL ones. > >That was intentional, even though it

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
On October 8, 2018 8:03:56 AM PDT, Tom Lane wrote: >Andres Freund writes: >> Where is the jit=on coming from? Config from before it was turned >off? > >A look in guc.c shows that jit defaults to "on" whether or not JIT is >enabled at compile time. I thought Pavel was talking about 11 somehow

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 16:58 odesílatel Andres Freund napsal: > Hi > > On October 8, 2018 2:51:15 AM PDT, Pavel Stehule > wrote: > >Hi > > > >I configured PostgreSQL without JIT support, but JIT is active by > >default > > > >postgres=# show jit; > >┌─┐ > >│ jit │ > >╞═╡ > >│ on │ > >└─┘

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Tom Lane
Andres Freund writes: > Where is the jit=on coming from? Config from before it was turned off? A look in guc.c shows that jit defaults to "on" whether or not JIT is enabled at compile time. This seems, at best, rather user-unfriendly. And it's not like our conventions for other compile-option-af

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Andres Freund
Hi On October 8, 2018 2:51:15 AM PDT, Pavel Stehule wrote: >Hi > >I configured PostgreSQL without JIT support, but JIT is active by >default > >postgres=# show jit; >┌─┐ >│ jit │ >╞═╡ >│ on │ >└─┘ >(1 row) Where is the jit=on coming from? Config from before it was turned off? >Un

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Pavel Stehule
po 8. 10. 2018 v 12:06 odesílatel Thomas Munro < thomas.mu...@enterprisedb.com> napsal: > On Mon, Oct 8, 2018 at 10:52 PM Pavel Stehule > wrote: > > > > Hi > > > > I configured PostgreSQL without JIT support, but JIT is active by default > > I think that happens when llvmjit.so is present (ie fro

Re: PostgreSQL 12, JIT defaults

2018-10-08 Thread Thomas Munro
On Mon, Oct 8, 2018 at 10:52 PM Pavel Stehule wrote: > > Hi > > I configured PostgreSQL without JIT support, but JIT is active by default I think that happens when llvmjit.so is present (ie from last time you built with JIT support and ran make install). You need to remove it. -- Thomas Munro h