Re: Persist injection points across server restarts

On Tue, Jun 03, 2025 at 03:34:16PM -0400, Andres Freund wrote: > I'm somewhat doubtful this is is the right direction. Tests that require > injection points before consistency also can't wait for injection points using > the SQL interface or such, so most of the stuff has to be written in C > anywa

Re: Persist injection points across server restarts

Hi, On 2025-06-03 13:13:06 +0900, Michael Paquier wrote: > On Mon, Jun 02, 2025 at 12:42:35PM -0700, Jeff Davis wrote: > > This seems like a fair amount of complexity for a single use case. > > Arguably, complexity around testing infrastructure is a lot less of a > > problem than other kinds of co

Re: Persist injection points across server restarts

On Tue, 2025-06-03 at 13:13 +0900, Michael Paquier wrote: > In all the approaches I've considered, this one was the least worst > of > all based on the point that all the complexity is hidden in the test > module; there is no need to touch the backend code at all as long as > there is a way to retr

Re: Persist injection points across server restarts

On Mon, Jun 02, 2025 at 12:42:35PM -0700, Jeff Davis wrote: > Unless that other thread is blocked for some reason, I'd suggest just > going ahead with the SQL callable function first. That seems > independently useful. Thanks. Having InjectionPointList() was also required for the other thread. >

Re: Persist injection points across server restarts

On Wed, 2025-04-30 at 14:35 +0900, Michael Paquier wrote: > - 0001 is a patch I have stolen from a different thread (see [1]), > introducing InjectionPointList() that retrieves a list of the > injection points attached. Unless that other thread is blocked for some reason, I'd suggest just going ah

Re: Persist injection points across server restarts

> On 27 May 2025, at 05:51, Michael Paquier wrote: > > > > I've made another round of looking into these patches. I think it's fine that private data is not included. But the feature looks orthogonal, and I do not see specific reasons why it should be omitted when IPs are persisted. An

Re: Persist injection points across server restarts

Hi Michael, On Fri, May 30, 2025 at 5:01 AM Michael Paquier wrote: > On Thu, May 29, 2025 at 01:17:21PM +0530, Rahila Syed wrote: > > After applying the v3-patches, I see failure like these: > > macOS - Sonoma - Meson - Cirrus CI > > > > Windows - Se

Re: Persist injection points across server restarts

On Thu, May 29, 2025 at 01:17:21PM +0530, Rahila Syed wrote: > After applying the v3-patches, I see failure like these: > macOS - Sonoma - Meson - Cirrus CI > > Windows - Server 2019, VS 2019 - Meson & ninja - Cirrus CI >

Re: Persist injection points across server restarts

Hi, Thank you for addressing the review comments. > It appears that Github CI is reporting failures with > > injection_points/002_data_persist > > failing across all OSes. > > I am not sure to see what you are referring to here, based on the > following reports: > https://commitfest.postgresql.or

Re: Persist injection points across server restarts

On Mon, May 26, 2025 at 01:17:46PM +0530, Rahila Syed wrote: > It appears that Github CI is reporting failures with > injection_points/002_data_persist > failing across all OSes. I am not sure to see what you are referring to here, based on the following reports: https://commitfest.postgresql.org/

Re: Persist injection points across server restarts

Hi, > This is v19 work, so I am adding that to the next commit fest. > > Rebased, to fix a conflict I've introduced with a different commit. > > Thank you for the rebased patches. I reviewed the code and have a few comments for your consideration. It appears that Github CI is reporting failures

Re: Persist injection points across server restarts

On Wed, May 21, 2025 at 12:17:55PM +0300, Andrey Borodin wrote: > I've looked into the patch set and have some more questions: > 1. What if we flush many times? Is it supposed to overwrite > injection_points.data? Yes. > 2. What if we restart many times? first startup will remove the file... may

Re: Persist injection points across server restarts

> On 21 May 2025, at 11:20, Michael Paquier wrote: > > Rebased, to fix a conflict I've introduced with a different commit. I've looked into the patch set and have some more questions: 1. What if we flush many times? Is it supposed to overwrite injection_points.data? 2. What if we restart man

Re: Persist injection points across server restarts

On Wed, Apr 30, 2025 at 02:35:40PM +0900, Michael Paquier wrote: > This is v19 work, so I am adding that to the next commit fest. Rebased, to fix a conflict I've introduced with a different commit. -- Michael From f84213eab2fc324f0e92ca7c55e164da6b2a74ee Mon Sep 17 00:00:00 2001 From: Michael Paqu

Re: Persist injection points across server restarts

On Wed, Apr 30, 2025 at 10:52:51AM +0500, Andrey Borodin wrote: > Did you consider custom resource manager to WAL-log injection > points? This way we do not need to flush them explicitly, they > always will be persistent. WAL-logging would not work in the case I've faced, because we need a point m

Re: Persist injection points across server restarts

> On 30 Apr 2025, at 10:35, Michael Paquier wrote: > > - A flush is used to write the points' data to disk. Interesting functionality. Did you consider custom resource manager to WAL-log injection points? This way we do not need to flush them explicitly, they always will be persistent. Thoug