This entry has been waiting on author input for a while (our current
threshold is roughly two weeks), so I've marked it Returned with
Feedback.
Once you think the patchset is ready for review again, you (or any
interested party) can resurrect the patch entry by visiting
https://commitfest.pos
This patch still has code warnings on the cfbot and I don't think
they're platform-specific:
[00:28:28.236] gram.y: In function ‘base_yyparse’:
[00:28:28.236] gram.y:2851:58: error: passing argument 2 of
‘makeDefElemExtended’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
[00:
On Tue, Mar 22, 2022 at 7:24 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-02-24 12:26:08 +0530, Sadhuprasad Patro wrote:
> > I have added a dummy test module for table AM and did the document
> > change in the latest patch attached...
>
> The test module doesn't build on windows, unfortunately... L
Hi,
On 2022-02-24 12:26:08 +0530, Sadhuprasad Patro wrote:
> I have added a dummy test module for table AM and did the document
> change in the latest patch attached...
The test module doesn't build on windows, unfortunately... Looks like you need
to add PGDLLIMPORT to a few variables:
[01:26:18.
On Fri, Feb 18, 2022 at 10:48 PM Simon Riggs
wrote:
>
> On Thu, 17 Feb 2022 at 17:55, Sadhuprasad Patro wrote:
> >
> > > On Sat, Feb 12, 2022 at 2:35 AM Robert Haas wrote:
> > >>
> > >>
> > >> Imagine that I am using the "foo" tableam with "compression=lots" and
> > >> I want to switch to the "b
On Thu, 17 Feb 2022 at 17:55, Sadhuprasad Patro wrote:
>
> > On Sat, Feb 12, 2022 at 2:35 AM Robert Haas wrote:
> >>
> >>
> >> Imagine that I am using the "foo" tableam with "compression=lots" and
> >> I want to switch to the "bar" AM which does not support that option.
> >> If I remove the "comp
> On Sat, Feb 12, 2022 at 2:35 AM Robert Haas wrote:
>>
>>
>> Imagine that I am using the "foo" tableam with "compression=lots" and
>> I want to switch to the "bar" AM which does not support that option.
>> If I remove the "compression=lots" option using a separate command,
>> the "foo" table AM m
On Sat, Feb 12, 2022 at 2:35 AM Robert Haas wrote:
>
> Imagine that I am using the "foo" tableam with "compression=lots" and
> I want to switch to the "bar" AM which does not support that option.
> If I remove the "compression=lots" option using a separate command,
> the "foo" table AM may rewrit
On Wed, Dec 29, 2021 at 12:08 PM Sadhuprasad Patro wrote:
> Open Question: When a user changes AM, then what should be the
> behavior for not supported storage options? Should we drop the options
> and go with only system storage options?
> Or throw an error, in which case the user has to clean th
On Tue, 2022-01-18 at 22:44 +0530, Sadhuprasad Patro wrote:
> As of now, I have fixed the comments from Dilip & Rushabh and have
> done some more changes after internal testing and review. Please find
> the latest patch attached.
Hi,
Thank you for working on this! Some questions/comments:
At a h
On Mon, Jan 17, 2022 at 4:47 PM Jelte Fennema wrote:
>
> Big +1, this is a great addition!
>
> I think it would be very useful if there were some tests for this new
> feature. Something similar to the tests for storage parameters for
> index AMs in src/test/modules/dummy_index_am.
>
Sure, I will r
Big +1, this is a great addition!
I think it would be very useful if there were some tests for this new
feature. Something similar to the tests for storage parameters for
index AMs in src/test/modules/dummy_index_am.
Apart from that I think the documentation for table storage parameters
needs to
On Wed, Dec 29, 2021 at 10:38 PM Sadhuprasad Patro
wrote:
> Hi,
>
> Currently all the storage options for a table are very much specific
> to the heap but a different AM might need some user defined AM
> specific parameters to help tune the AM. So here is a patch which
> provides an AM level rout
On Wed, Dec 29, 2021 at 10:38 PM Sadhuprasad Patro
wrote:
> Hi,
>
> Currently all the storage options for a table are very much specific
> to the heap but a different AM might need some user defined AM
> specific parameters to help tune the AM. So here is a patch which
> provides an AM level rout
14 matches
Mail list logo
