Re: Patch to avoid orphaned dependencies

2024-04-22 Thread Bertrand Drouvot
Hi, On Wed, Mar 23, 2022 at 12:49:06PM -0400, Tom Lane wrote: > Realistically, if we want to prevent this type of problem, then all > creation DDL will have to take a lock on each referenced object that'd > conflict with a lock taken by DROP. This might not be out of reach: > I think we do alread

Re: Patch to avoid orphaned dependencies

2022-08-02 Thread Jacob Champion
This entry has been waiting on author input for a while (our current threshold is roughly two weeks), so I've marked it Returned with Feedback. Once you think the patchset is ready for review again, you (or any interested party) can resurrect the patch entry by visiting https://commitfest.pos

Re: Patch to avoid orphaned dependencies

2022-03-30 Thread Nathan Bossart
On Wed, Mar 23, 2022 at 12:49:06PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> Bertand, do you think this has any chance of making it into v15? If not, >> are you alright with adjusting the commitfest entry to v16 and moving it to >> the next commitfest? > > I looked this over briefly, an

Re: Patch to avoid orphaned dependencies

2022-03-23 Thread Tom Lane
Nathan Bossart writes: > Bertand, do you think this has any chance of making it into v15? If not, > are you alright with adjusting the commitfest entry to v16 and moving it to > the next commitfest? I looked this over briefly, and IMO it should have no chance of being committed in anything like

Re: Patch to avoid orphaned dependencies

2022-03-17 Thread Nathan Bossart
Bertand, do you think this has any chance of making it into v15? If not, are you alright with adjusting the commitfest entry to v16 and moving it to the next commitfest? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: Patch to avoid orphaned dependencies

2022-01-04 Thread Zhihong Yu
Hi, For genam.c: + UseDirtyCatalogSnapshot = dirtysnap; + Does the old value of UseDirtyCatalogSnapshot need to be restored at the end of the func ? +systable_recheck_tuple(SysScanDesc sysscan, HeapTuple tup, bool dirtysnap) Considering that parameter dirtysnap is a bool, I think it should be

Re: Patch to avoid orphaned dependencies

2021-12-30 Thread Andres Freund
Hi, On 2021-12-17 14:19:18 +0100, Drouvot, Bertrand wrote: > Please find enclosed v1-0003-orphaned-dependencies.patch, that contains: > > - a mandatory rebase > > - a few isolation tests added in src/test/modules/test_dependencies (but I'm > not sure at all that's the right place to add them, is

Re: Patch to avoid orphaned dependencies

2021-11-17 Thread Daniel Gustafsson
> On 20 Sep 2021, at 12:50, Drouvot, Bertrand wrote: > > Hi Ronan, > > On 9/17/21 10:09 AM, Ronan Dunklau wrote: >> Hello Bertrand, >> >> Le mardi 4 mai 2021, 11:55:43 CEST Drouvot, Bertrand a écrit : >>> Implementation overview: >>> >>> * A new catalog snapshot is added: DirtyCatalo

Re: Patch to avoid orphaned dependencies

2021-09-17 Thread Ronan Dunklau
Hello Bertrand, Le mardi 4 mai 2021, 11:55:43 CEST Drouvot, Bertrand a écrit : > > Implementation overview: > > * A new catalog snapshot is added: DirtyCatalogSnapshot. > * This catalog snapshot is a dirty one to be able to look for > in-flight dependencies. > * Its usage is co