Committed.
--
nathan
On Wed, Dec 25, 2024 at 01:15:53PM +0800, Japin Li wrote:
> It seems that the v11 cannot apply on master since 7f97b4734, and rebase is
> needed.
>
> $ git am ~/v11-0001-Add-passwordcheck.min_password_length.patch
> Applying: Add passwordcheck.min_password_length.
> error: patch failed: contrib/p
On Thu, 19 Dec 2024 at 09:57, Nathan Bossart wrote:
> On Thu, Dec 19, 2024 at 09:36:17AM -0600, Nathan Bossart wrote:
>> On Thu, Dec 19, 2024 at 07:25:30AM +, Bertrand Drouvot wrote:
>>> -errmsg("password is too short")));
>>> +
On Thu, Dec 19, 2024 at 09:57:31AM -0600, Nathan Bossart wrote:
> On Thu, Dec 19, 2024 at 09:36:17AM -0600, Nathan Bossart wrote:
> > On Thu, Dec 19, 2024 at 07:25:30AM +, Bertrand Drouvot wrote:
> >> - errmsg("password is too short")));
> >> +
On Thu, Dec 19, 2024 at 09:36:17AM -0600, Nathan Bossart wrote:
> On Thu, Dec 19, 2024 at 07:25:30AM +, Bertrand Drouvot wrote:
>> - errmsg("password is too short")));
>> + errmsg("password is too short: %d (<
>> %d)", pwd
On Thu, Dec 19, 2024 at 11:22:02AM +0100, Emanuele Musella wrote:
> It seems to me you are working on an older version of patch.
>
> In attached the latest one for your reference.
I used the v9 patch as the basis for v10. There are a few small edits,
such as removing the upper bound for the para
On Thu, Dec 19, 2024 at 07:25:30AM +, Bertrand Drouvot wrote:
> + if (pwdlen < min_password_length)
>ereport(ERROR,
>(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("password is too short")));
>
> Now that the minimum password length is
Hi Nathan,
thank you.
It seems to me you are working on an older version of patch.
In attached the latest one for your reference.
Thanks for your support
Best regards
Emanuele Musella
Il giorno mer 18 dic 2024 alle ore 21:56 Nathan Bossart <
nathandboss...@gmail.com> ha scritto:
> Here is
Hi,
On Wed, Dec 18, 2024 at 02:56:24PM -0600, Nathan Bossart wrote:
> Here is what I have staged for commit.
Thanks!
A few comments:
=== 1
+ if (pwdlen < min_password_length)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("pa
Here is what I have staged for commit.
--
nathan
>From 537260d0492ad3bda2c2fcbfd00c6b0511f5e1b5 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 18 Dec 2024 14:49:20 -0600
Subject: [PATCH v10 1/1] Add passwordcheck.min_password_length.
This new parameter can be used to change the minimu
Sorry here the right attachment
Il giorno lun 25 nov 2024 alle ore 11:15 Emanuele Musella <
emamus...@gmail.com> ha scritto:
> Thank you Bertrand for your feedbacks. We are looking for CFbot part so we
> can compile it like CFbot.
>
> For now we have fixed all points.
>
> Thank you
>
> Il giorno
Thank you Bertrand for your feedbacks. We are looking for CFbot part so we
can compile it like CFbot.
For now we have fixed all points.
Thank you
Il giorno mar 19 nov 2024 alle ore 20:28 Bertrand Drouvot <
bertranddrouvot...@gmail.com> ha scritto:
> Hi,
>
> On Mon, Nov 18, 2024 at 05:21:18PM +0
On Wed, Nov 20, 2024 at 07:45:40AM +0900, Michael Paquier wrote:
> On Tue, Nov 12, 2024 at 02:48:28PM +0100, Tomas Vondra wrote:
>> Thanks for the patch, seems like a useful feature. Please add the patch
>> to the next commitfest (2025-01) at https://commitfest.postgresql.org/
>
> FYI, I have a la
On Tue, Nov 12, 2024 at 02:48:28PM +0100, Tomas Vondra wrote:
> Thanks for the patch, seems like a useful feature. Please add the patch
> to the next commitfest (2025-01) at https://commitfest.postgresql.org/
FYI, I have a large set of such things in my own repo with a clone of
passwordcheck:
http
Hi,
On Mon, Nov 18, 2024 at 05:21:18PM +0100, Emanuele Musella wrote:
> We notice some errors on CFBot results.
FWIW, you can run "cfbot like" tests on your own repo (see [1]).
> In attached the errors fixed
Thanks for the updated version!
A few random comments:
=== 1
trailing whitespace:
$
We notice some errors on CFBot results.
In attached the errors fixed
Il giorno lun 18 nov 2024 alle ore 16:59 Emanuele Musella <
emamus...@gmail.com> ha scritto:
> Hello Bertrand,
>
> thank you for your feedbacks.
>
> We have done every fixes required.
>
> In attach the last version.
>
> Best re
Hello Bertrand,
thank you for your feedbacks.
We have done every fixes required.
In attach the last version.
Best regards
Il giorno lun 18 nov 2024 alle ore 11:39 Bertrand Drouvot <
bertranddrouvot...@gmail.com> ha scritto:
> Hi,
>
> On Mon, Nov 18, 2024 at 10:01:41AM +0100, Emanuele Musella
Hi,
On Mon, Nov 18, 2024 at 10:01:41AM +0100, Emanuele Musella wrote:
> Hi all,
>
> we have fixed the following warning from the CFbot:
>
> [07:14:29.637] passwordcheck.c:37:5: error: no previous extern declaration
> for non-static variable 'min_password_length'
> [-Werror,-Wmissing-variable-dec
Hi all,
we have fixed the following warning from the CFbot:
[07:14:29.637] passwordcheck.c:37:5: error: no previous extern declaration
for non-static variable 'min_password_length'
[-Werror,-Wmissing-variable-declarations]
In attach the fixed patch.
Best regards
Il giorno mer 13 nov 2024 alle
Hi Tomas,
we have done the fixes that you have suggested us in the last mail.
1) Modified passwordcheck.sql with a_nice_long_password and also
passwordcheck.out
2) we added the documentation in the doc/src/sgml/passwordcheck.sgml.
3) we have done make check successfully.
If you have other sugg
Hi,
On 11/12/24 14:41, Emanuele Musella wrote:
> The goal about this patch is to parameterize the minimum password lenght
> on users database and apply it on the general code.
> The patch is applicable to the master branch.
> We already tested it: it build and works as expected and nothing is
> fo
21 matches
Mail list logo
