Re: PG versus libxml2 2.12.x

2024-01-29 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> In PL/Tcl, we used to have these CONST84 and CONST86 things, for similar >> reasons. Maybe that would be another approach. > Yeah, if the simple cast approach turns out to create warnings, > we'll have to fall back on using actually different declarations.

Re: PG versus libxml2 2.12.x

2024-01-29 Thread Tom Lane
Peter Eisentraut writes: > On 27.01.24 20:04, Tom Lane wrote: >> I don't mind adopting the "const" --- it's a good idea in isolation. >> The trouble is in fixing our code to work with both old and new >> libxml2 versions. We could thrash around with a configure test or >> something, but I think t

Re: PG versus libxml2 2.12.x

2024-01-29 Thread Peter Eisentraut
On 27.01.24 20:04, Tom Lane wrote: Buildfarm member caiman has been failing build for a couple weeks now. The reason turns out to be that recent libxml2 has decided to throw a "const" into the signature required for custom error handlers. (API compatibility? What's that?) I don't mind adopting

Re: PG versus libxml2 2.12.x

2024-01-29 Thread Andrew Dunstan
On 2024-01-27 Sa 14:04, Tom Lane wrote: Buildfarm member caiman has been failing build for a couple weeks now. The reason turns out to be that recent libxml2 has decided to throw a "const" into the signature required for custom error handlers. (API compatibility? What's that?) I don't mind ad