Re: PERIOD foreign key feature

2024-05-09 Thread Bruce Momjian
On Wed, May 8, 2024 at 08:47:45PM -0700, Paul Jungwirth wrote: > On 5/8/24 07:44, Bruce Momjian wrote: > > On Wed, May 8, 2024 at 02:29:34PM +0200, Peter Eisentraut wrote: > > > > Yes, David is correct here on all points. I like his suggestion to > > > > clarify the language here also. If you nee

Re: PERIOD foreign key feature

2024-05-08 Thread Paul Jungwirth
On 5/8/24 07:44, Bruce Momjian wrote: On Wed, May 8, 2024 at 02:29:34PM +0200, Peter Eisentraut wrote: Yes, David is correct here on all points. I like his suggestion to clarify the language here also. If you need a patch from me let me know, but I assume it's something a committer can just mak

Re: PERIOD foreign key feature

2024-05-08 Thread Bruce Momjian
On Wed, May 8, 2024 at 02:29:34PM +0200, Peter Eisentraut wrote: > > > Finally, if the foreign key has a PERIOD column_name specification > > > the corresponding refcolumn, if present, must also be marked > > > PERIOD.  If the refcolumn clause is omitted, and thus the reftable's > > > primary key

Re: PERIOD foreign key feature

2024-05-08 Thread Peter Eisentraut
On 07.05.24 18:43, Paul Jungwirth wrote: On 5/7/24 08:23, David G. Johnston wrote: On Tue, May 7, 2024 at 7:54 AM Bruce Momjian > wrote:     In the two marked lines, it says "if one side of the foreign key uses     PERIOD, the other side must too."  However, looking at t

Re: PERIOD foreign key feature

2024-05-07 Thread Paul Jungwirth
On 5/7/24 08:23, David G. Johnston wrote: On Tue, May 7, 2024 at 7:54 AM Bruce Momjian mailto:br...@momjian.us>> wrote: In the two marked lines, it says "if one side of the foreign key uses PERIOD, the other side must too."  However, looking at the example queries, it seems like if th

Re: PERIOD foreign key feature

2024-05-07 Thread David G. Johnston
On Tue, May 7, 2024 at 7:54 AM Bruce Momjian wrote: > In this commit: > > commit 34768ee3616 > Author: Peter Eisentraut > Date: Sun Mar 24 07:37:13 2024 +0100 > > Add temporal FOREIGN KEY contraints > > Add PERIOD clause to foreign key constraint