Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes

2025-02-14 Thread Andreas Karlsson
On 2/11/25 9:25 PM, Tom Lane wrote: Greg Sabino Mullane writes: I say "of course" but few people (even tech ones) know the distinction. (Nor should they have to! But that's for a nearby thread). This patch aims to prevent this very bad footgun by only allowing a /0 if the IP consists of only ze

Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes

2025-02-11 Thread Greg Sabino Mullane
On Tue, Feb 11, 2025 at 3:25 PM Tom Lane wrote: > More generally, should we reject if the netmask causes *any* nonzero > IP bits to be ignored? Our CIDR type already imposes that rule: > Yeah, I like that idea a lot. That's a great DETAIL message. Cheers, Greg -- Crunchy Data - https://www.cr

Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes

2025-02-11 Thread Daniel Gustafsson
> On 11 Feb 2025, at 21:25, Tom Lane wrote: > I'm a bit distressed to realize that hba.c isn't using cidr_in. > Maybe we should try to share code instead of duplicating yet more. +1. I have a note along these lines on my never-shrinking TODO, I think it would be great if we took a stab at that.

Re: PATCH: Disallow a netmask of zero unless the IP is also all zeroes

2025-02-11 Thread Tom Lane
Greg Sabino Mullane writes: > I say "of course" but few people (even tech ones) know the distinction. > (Nor should they have to! But that's for a nearby thread). This patch aims > to prevent this very bad footgun by only allowing a /0 if the IP consists > of only zeroes. It works for ipv4 and ipv