I think it's clear we aren't going to be taking this patch in its
current form. Perhaps there are better ways to do what these files do
(I sure think there are!) but I don't think microoptimizing the
copying is something people are super excited about. It sounds like
rethinking how to make these fu
Ranier Vilela writes:
> Em qua., 4 de jan. de 2023 às 19:39, Tom Lane escreveu:
>> Yeah. The way that I'd been thinking of optimizing the copy functions
>> was more or less as attached: continue to write all the COPY_SCALAR_FIELD
>> macro calls, but just make them expand to no-ops after an initi
Em qua., 4 de jan. de 2023 às 19:39, Tom Lane escreveu:
> vignesh C writes:
> > The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
>
> Yeah. The way that I'd been thinking of optimizing the copy functions
> was more or less as attached: continue to write all the C
vignesh C writes:
> The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
Yeah. The way that I'd been thinking of optimizing the copy functions
was more or less as attached: continue to write all the COPY_SCALAR_FIELD
macro calls, but just make them expand to no-ops
On Fri, 2 Dec 2022 at 19:06, Ranier Vilela wrote:
>
> Hi, thanks for reviewing this.
>
> Em sex., 2 de dez. de 2022 às 09:24, John Naylor
> escreveu:
>>
>>
>> On Thu, Dec 1, 2022 at 8:02 PM Ranier Vilela wrote:
>> >
>> > Hi,
>> >
>> > I believe that has room for improving generation node files.
Hi, thanks for reviewing this.
Em sex., 2 de dez. de 2022 às 09:24, John Naylor <
john.nay...@enterprisedb.com> escreveu:
>
> On Thu, Dec 1, 2022 at 8:02 PM Ranier Vilela wrote:
> >
> > Hi,
> >
> > I believe that has room for improving generation node files.
> >
> > The patch attached reduced th
On Thu, Dec 1, 2022 at 8:02 PM Ranier Vilela wrote:
>
> Hi,
>
> I believe that has room for improving generation node files.
>
> The patch attached reduced the size of generated files by 27 kbytes.
> From 891 kbytes to 864 kbytes.
>
> About the patch:
> 1. Avoid useless attribution when from->fiel
