Re: Optimising numeric division

2024-10-04 Thread Dean Rasheed
On Sun, 25 Aug 2024 at 10:33, Joel Jacobson wrote: > > Nice. LGTM. > I've successfully tested the new patch again on both Intel and AMD. > > I've marked it as Ready for Committer. > [Finally getting back to this] Thanks for the review and testing. Committed. Regards, Dean

Re: Optimising numeric division

2024-08-25 Thread Joel Jacobson
On Sat, Aug 24, 2024, at 14:10, Dean Rasheed wrote: > On Sat, 24 Aug 2024 at 08:26, Joel Jacobson wrote: >> >> On Sat, Aug 24, 2024, at 01:35, Joel Jacobson wrote: >> > On Sat, Aug 24, 2024, at 00:00, Joel Jacobson wrote: >> >> Since statistical tools that rely on normal distributions can't be use

Re: Optimising numeric division

2024-08-24 Thread Dean Rasheed
On Sat, 24 Aug 2024 at 08:26, Joel Jacobson wrote: > > On Sat, Aug 24, 2024, at 01:35, Joel Jacobson wrote: > > On Sat, Aug 24, 2024, at 00:00, Joel Jacobson wrote: > >> Since statistical tools that rely on normal distributions can't be used, > >> let's look at the individual measurements for (var

Re: Optimising numeric division

2024-08-24 Thread Joel Jacobson
On Sat, Aug 24, 2024, at 01:35, Joel Jacobson wrote: > On Sat, Aug 24, 2024, at 00:00, Joel Jacobson wrote: >> Since statistical tools that rely on normal distributions can't be used, >> let's look at the individual measurements for (var1ndigits=3, var2ndigits=3) >> since that seems to be the bigge

Re: Optimising numeric division

2024-08-23 Thread Joel Jacobson
On Sat, Aug 24, 2024, at 00:00, Joel Jacobson wrote: > Since statistical tools that rely on normal distributions can't be used, > let's look at the individual measurements for (var1ndigits=3, var2ndigits=3) > since that seems to be the biggest slowdown on both CPUs, > and see if our level of surpri

Re: Optimising numeric division

2024-08-23 Thread Joel Jacobson
On Fri, Aug 23, 2024, at 21:21, Joel Jacobson wrote: > Attachments: > * perf_test-M3 Max.out > * perf_test-Intel Core i9-14900K.out > * perf_test-AMD Ryzen 9 7950X3D.out Here are some additional benchmarks from pg-catbench: AMD Ryzen 9 7950X3D: select x var1ndigits,y var2ndigits,a_avg,b_avg,poo

Re: Optimising numeric division

2024-08-23 Thread Joel Jacobson
On Fri, Aug 23, 2024, at 21:21, Joel Jacobson wrote: > On Fri, Aug 23, 2024, at 15:49, Dean Rasheed wrote: >> The attached patch attempts to resolve those issues by replacing >> div_var() and div_var_fast() with a single function intended to be >> faster than both the originals. ... > I've had an i