Re: On the stability of TAP tests for LDAP

2019-07-25 Thread Michael Paquier
On Fri, Jul 26, 2019 at 10:18:48AM +1200, Thomas Munro wrote: > Pushed, thanks. Thanks for fixing! I'll update this thread if there are still some problems. -- Michael signature.asc Description: PGP signature

Re: On the stability of TAP tests for LDAP

2019-07-25 Thread Thomas Munro
On Thu, Jul 25, 2019 at 12:51 PM Michael Paquier wrote: > Thanks for the updated patch, this looks good. I have done a series > of tests keeping my laptop busy and I haven't seen a failure where I > usually see problems 10%~20% of the time. So that seems to help, > thanks! Pushed, thanks. --

Re: On the stability of TAP tests for LDAP

2019-07-24 Thread Michael Paquier
On Wed, Jul 24, 2019 at 09:01:47PM +1200, Thomas Munro wrote: > Huh, yeah, I don't know why slapd requires credentials on Debian, when > the version that ships with FreeBSD is OK with an anonymous > connection. Rather than worrying about that, I just adjusted it to > supply the credentials. It wo

Re: On the stability of TAP tests for LDAP

2019-07-24 Thread Thomas Munro
On Wed, Jul 24, 2019 at 7:50 PM Michael Paquier wrote: > Perhaps this worked on freebsd? Now that I test it, the test gets > stuck on my Debian box: > # waiting for slapd to accept requests... > # Running: ldapsearch -h localhost -p 49534 -s base -b > dc=example,dc=net -n 'objectclass=*' > SASL/D

Re: On the stability of TAP tests for LDAP

2019-07-24 Thread Michael Paquier
On Wed, Jul 24, 2019 at 05:47:13PM +1200, Thomas Munro wrote: > Thanks, here's v2. Perhaps this worked on freebsd? Now that I test it, the test gets stuck on my Debian box: # waiting for slapd to accept requests... # Running: ldapsearch -h localhost -p 49534 -s base -b dc=example,dc=net -n 'objec

Re: On the stability of TAP tests for LDAP

2019-07-23 Thread Thomas Munro
On Wed, Jul 24, 2019 at 5:26 PM Michael Paquier wrote: > > Does this look about right? > > Some comments from here. I have not tested the patch. > > I would recommend using TestLib::system_log instead of plain system(). > The command should be a list of arguments with one element per > argument (

Re: On the stability of TAP tests for LDAP

2019-07-23 Thread Michael Paquier
On Wed, Jul 24, 2019 at 04:41:05PM +1200, Thomas Munro wrote: > On Wed, Jul 24, 2019 at 3:52 PM Thomas Munro wrote: > > I guess we should do that too. I don't know how to write Perl but I'll > > try... > > Does this look about right? Some comments from here. I have not tested the patch. I wo

Re: On the stability of TAP tests for LDAP

2019-07-23 Thread Thomas Munro
On Wed, Jul 24, 2019 at 3:52 PM Thomas Munro wrote: > I guess we should do that too. I don't know how to write Perl but I'll try... Does this look about right? -- Thomas Munro https://enterprisedb.com wait-for-slapd.patch Description: Binary data

Re: On the stability of TAP tests for LDAP

2019-07-23 Thread Thomas Munro
On Fri, Jul 19, 2019 at 3:30 PM Michael Paquier wrote: > # Running: /usr/sbin/slapd -f > /home/bf/bfr/root/HEAD/pgsql.build/src/test/ldap/tmp_check/slapd.conf > -h ldap://localhost:55306 ldaps://localhost:55307 > # loading LDAP data > # Running: ldapadd -x -y > /home/bf/bfr/root/HEAD/pgsql.build