Re: Occasional tablespace.sql failures in check-world -jnn

2021-03-10 Thread Andres Freund
Hi, On 2021-03-10 15:40:38 +0900, Michael Paquier wrote: > On Mon, Mar 08, 2021 at 11:53:57AM +0100, Peter Eisentraut wrote: > > On 09.12.20 08:55, Michael Paquier wrote: > >> ... Because we may still introduce this problem again if some new > >> stuff uses src/test/pg_regress in a way similar to

Re: Occasional tablespace.sql failures in check-world -jnn

2021-03-09 Thread Michael Paquier
On Mon, Mar 08, 2021 at 11:53:57AM +0100, Peter Eisentraut wrote: > On 09.12.20 08:55, Michael Paquier wrote: >> ... Because we may still introduce this problem again if some new >> stuff uses src/test/pg_regress in a way similar to pg_upgrade, >> triggering again tablespace-setup. Something like

Re: Occasional tablespace.sql failures in check-world -jnn

2021-03-08 Thread Peter Eisentraut
On 09.12.20 08:55, Michael Paquier wrote: It's not clear to me why we have this logic in the makefile at all? Somebody taught pg_regress to do so, but only on windows... See convert_sourcefiles_in(). ... Because we may still introduce this problem again if some new stuff uses src/test/pg_regre

Re: Occasional tablespace.sql failures in check-world -jnn

2021-01-15 Thread Michael Paquier
On Fri, Jan 15, 2021 at 09:59:02AM +0100, Peter Eisentraut wrote: > I vaguely recall that this had something to do with SELinux (or something > similar?), where it matters in what context you create a file or directory > and then certain properties attach to it that are relevant to subsequent > pro

Re: Occasional tablespace.sql failures in check-world -jnn

2021-01-15 Thread Peter Eisentraut
On 2020-12-09 02:29, Andres Freund wrote: I suspect this is related to the pg_upgrade test and the main regression test running at the same time. We have the following in src/test/regress/GNUMakefile # Tablespace setup .PHONY: tablespace-setup tablespace-setup: echo $(realpath ./testta

Re: Occasional tablespace.sql failures in check-world -jnn

2020-12-08 Thread Michael Paquier
On Tue, Dec 08, 2020 at 05:29:11PM -0800, Andres Freund wrote: > I suspect this is related to the pg_upgrade test and the main regression > test running at the same time. We have the following in > src/test/regress/GNUMakefile. Yes, this one is not completely new to -hackers. See patch 0002 here