Re: Multi-byte character case-folding

2020-07-14 Thread Bruce Momjian
On Mon, Jul 6, 2020 at 08:32:22PM -0400, Tom Lane wrote: > Yes, a GUC changing this would be a headache. It would be just as much of > a compatibility and security hazard as standard_conforming_strings (which > indeed I've been thinking of proposing that we get rid of; it's hung > around long eno

Re: Multi-byte character case-folding

2020-07-08 Thread Tom Lane
Robert Haas writes: > That's not to say that I have any good idea what to do about this. I > just disagree with labelling the above case as a success. I can't say that I like it either. But I'm afraid that changing it now will create many more problems than it solves. re

Re: Multi-byte character case-folding

2020-07-08 Thread Alvaro Herrera
On 2020-Jul-08, Robert Haas wrote: > That's not to say that I have any good idea what to do about this. I > just disagree with labelling the above case as a success. Yeah, particularly since it works differently in single-char encodings. -- Álvaro Herrerahttps://www.2ndQuadrant.

Re: Multi-byte character case-folding

2020-07-08 Thread Robert Haas
On Mon, Jul 6, 2020 at 8:32 PM Tom Lane wrote: > test=# create table MYÉCLASS (f1 text); > CREATE TABLE > test=# \dt > List of relations > Schema | Name | Type | Owner > +--+---+-- > public | myÉclass | table | postgres > (1 row) > > pg_dump will rende

Re: Multi-byte character case-folding

2020-07-07 Thread Tom Lane
"Daniel Verite" writes: > Tom Lane wrote: >> If we start to case-fold É, then the only way to access this table will >> be by double-quoting its name, which the application probably is not >> expecting (else it would have double-quoted in the original CREATE TABLE). > This problem already e

Re: Multi-byte character case-folding

2020-07-07 Thread Daniel Verite
Tom Lane wrote: > CREATE TABLE public."myÉclass" ( >f1 text > ); > > If we start to case-fold É, then the only way to access this table will > be by double-quoting its name, which the application probably is not > expecting (else it would have double-quoted in the original CREATE TABL

Re: Multi-byte character case-folding

2020-07-06 Thread Tom Lane
Alvaro Herrera writes: > On 2020-Jul-06, Tom Lane wrote: >> More generally, I'd be mighty hesitant to change this behavior after >> it's stood for so many years. I suspect more people would complain >> that we broke their application than would be happy about it. > I think the fact that identifi

Re: Multi-byte character case-folding

2020-07-06 Thread Alvaro Herrera
On 2020-Jul-06, Tom Lane wrote: > More generally, I'd be mighty hesitant to change this behavior after > it's stood for so many years. I suspect more people would complain > that we broke their application than would be happy about it. > > Having said that, we are already relying on towlower() i

Re: Multi-byte character case-folding

2020-07-06 Thread Tom Lane
Thom Brown writes: > At the moment, only single-byte characters in identifiers are > case-folded, and multi-byte characters are not. > ... > So my question is, do we yet have the infrastructure to make > case-folding consistent across all character widths? We still lack any built-in knowledge abo