Re: Missing deconstruct_array_builtin usage

2024-10-14 Thread Masahiko Sawada
On Mon, Oct 14, 2024 at 3:05 AM Peter Eisentraut wrote: > > On 14.10.24 08:12, Bertrand Drouvot wrote: > >> It seems that src/backend/utils/adt/float.c file still has functions > >> that can use [de]construct_array_builtin(), for example > >> float8_combine(). I think it's an oversight of d746021d

Re: Missing deconstruct_array_builtin usage

2024-10-14 Thread Peter Eisentraut
On 14.10.24 08:12, Bertrand Drouvot wrote: It seems that src/backend/utils/adt/float.c file still has functions that can use [de]construct_array_builtin(), for example float8_combine(). I think it's an oversight of d746021de1. Thanks for looking at it. Good catch, please find attached v2 taking

Re: Missing deconstruct_array_builtin usage

2024-10-13 Thread Bertrand Drouvot
Hi, On Fri, Oct 11, 2024 at 05:43:04PM -0700, Masahiko Sawada wrote: > Hi, > > On Thu, Oct 10, 2024 at 10:37 PM Bertrand Drouvot > wrote: > > > > Hi hackers, > > > > While working on [1], I noticed that we missed using > > deconstruct_array_builtin() > > in 062a8444242. > > > > Indeed, d746021d

Re: Missing deconstruct_array_builtin usage

2024-10-11 Thread Masahiko Sawada
Hi, On Thu, Oct 10, 2024 at 10:37 PM Bertrand Drouvot wrote: > > Hi hackers, > > While working on [1], I noticed that we missed using > deconstruct_array_builtin() > in 062a8444242. > > Indeed, d746021de1 added construct_array_builtin and deconstruct_array_builtin > but , later on, 062a8444242 m