Re: Minor adjustment to pg_aios output naming

2025-05-22 Thread Andres Freund
Hi, On 2025-05-21 15:43:01 -0400, Robert Haas wrote: > On Tue, May 20, 2025 at 10:45 PM Michael Paquier wrote: > > I think that your suggestion of fix is right. The properties are > > marked as "WRITEV" and "READV" for vectored operations. So the > > documentation is right, not the name used in

Re: Minor adjustment to pg_aios output naming

2025-05-21 Thread Michael Paquier
On Wed, May 21, 2025 at 03:43:01PM -0400, Robert Haas wrote: > Since this was Andres's commit, I think it would have been a good idea > to give at least 24 hours, or better yet a couple of days, for him to > comment before committing something. Thanks for the poke, sorry about that. I'll be more

Re: Minor adjustment to pg_aios output naming

2025-05-21 Thread Robert Haas
On Tue, May 20, 2025 at 10:45 PM Michael Paquier wrote: > I think that your suggestion of fix is right. The properties are > marked as "WRITEV" and "READV" for vectored operations. So the > documentation is right, not the name used in the code. Will fix, > thanks for the report. Since this was

Re: Minor adjustment to pg_aios output naming

2025-05-20 Thread Michael Paquier
On Wed, May 21, 2025 at 11:14:11AM +0900, torikoshia wrote: > Hi, > > I've noticed a minor inconsistency in the output of pg_aios. > > According to the documentation, the values for 'operation' are described as: > > readv, a vectored read > ... > writev, a vectored write > > However, in a