Re: MinIndexTupleSize seems slightly wrong

2018-04-14 Thread Peter Geoghegan
On Fri, Apr 13, 2018 at 10:45 AM, Tom Lane wrote: > As long as btree only has one no-data tuple per page, I think we are good, > because this calculation does not account for page special space. We might > be underestimating how many tuples can fit by one MAXALIGN quantum, but > the special space

Re: MinIndexTupleSize seems slightly wrong

2018-04-13 Thread Tom Lane
Kyotaro HORIGUCHI writes: > At Thu, 12 Apr 2018 17:26:33 -0700, Peter Geoghegan wrote in > >> However, that at least seems questionable to me. See _bt_pgaddtup() >> for a simple example of this -- "minus infinity" items on internal >> pages are sized sizeof(IndexTupleData). > MaxIndexTuplesPer

Re: MinIndexTupleSize seems slightly wrong

2018-04-12 Thread Kyotaro HORIGUCHI
At Thu, 12 Apr 2018 17:26:33 -0700, Peter Geoghegan wrote in > itup.h says of MinIndexTupleSize/MaxIndexTuplesPerPage: > > /* > * MaxIndexTuplesPerPage is an upper bound on the number of tuples that can > * fit on one index page. An index tuple must have either data or a null > * bitmap, so