Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-09-12 Thread Yugo NAGATA
On Wed, 13 Sep 2023 10:20:23 +0900 Michael Paquier wrote: > On Tue, Sep 12, 2023 at 03:18:05PM +0900, Michael Paquier wrote: > > On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote: > > > I attached the update patch. I removed the incorrect comments and > > > unnecessary lines. Also, I r

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-09-12 Thread Michael Paquier
On Tue, Sep 12, 2023 at 03:18:05PM +0900, Michael Paquier wrote: > On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote: > > I attached the update patch. I removed the incorrect comments and > > unnecessary lines. Also, I rewrote the test to use "skip_all" instead > > of SKIP because we ski

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-09-11 Thread Michael Paquier
On Wed, Sep 06, 2023 at 12:45:24AM +0900, Yugo NAGATA wrote: > I attached the update patch. I removed the incorrect comments and > unnecessary lines. Also, I rewrote the test to use "skip_all" instead > of SKIP because we skip the whole test rather than a part of it. Thanks for checking how IPC::

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-09-05 Thread Yugo NAGATA
On Mon, 14 Aug 2023 23:37:25 +0900 Yugo NAGATA wrote: > On Mon, 14 Aug 2023 08:29:25 +0900 > Michael Paquier wrote: > > > On Sun, Aug 13, 2023 at 11:22:33AM +0200, Fabien COELHO wrote: > > > Test run is ok on my Ubuntu laptop. > > > > I have a few comments about this patch. > > > > On HEAD an

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-08-14 Thread Yugo NAGATA
On Mon, 14 Aug 2023 08:29:25 +0900 Michael Paquier wrote: > On Sun, Aug 13, 2023 at 11:22:33AM +0200, Fabien COELHO wrote: > > Test run is ok on my Ubuntu laptop. > > I have a few comments about this patch. > > On HEAD and even after this patch, we still have the following: > SKIP:

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-08-13 Thread Fabien COELHO
Bonjour Michaƫl, On Sun, Aug 13, 2023 at 11:22:33AM +0200, Fabien COELHO wrote: Test run is ok on my Ubuntu laptop. I have a few comments about this patch. Argh, sorry! I looked at what was removed (a lot) from the previous version, not what was remaining and should also have been remove

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-08-13 Thread Michael Paquier
On Sun, Aug 13, 2023 at 11:22:33AM +0200, Fabien COELHO wrote: > Test run is ok on my Ubuntu laptop. I have a few comments about this patch. On HEAD and even after this patch, we still have the following: SKIP:

Re: Make psql's qeury canceling test simple by using signal() routine of IPC::Run

2023-08-13 Thread Fabien COELHO
Hello Yugo-san, Currently, the psql's test of query cancelling (src/bin/psql/t/020_cancel.pl) gets the PPID of a running psql by using "\!" meta command, and sends SIGINT to the process by using "kill". However, IPC::Run provides signal() routine that sends a signal to a running process, so I