Re: Make message strings in fe-connect.c consistent

2023-04-21 Thread Daniel Gustafsson
> On 21 Apr 2023, at 07:02, Gurjeet Singh wrote: > On Thu, Apr 20, 2023 at 9:31 PM Tom Lane wrote: libpq_append_conn_error(conn, "invalid require_auth method: \"%s\"", method); >> >> Yup, this one did not get the memo. I've pushed this, with the change to use the common "invalid %s v

Re: Make message strings in fe-connect.c consistent

2023-04-20 Thread Gurjeet Singh
On Thu, Apr 20, 2023 at 9:31 PM Tom Lane wrote: > > Gurjeet Singh writes: > > When reviewing a recently committed patch [1] I noticed the odd usage > > of a format specifier: > > > + libpq_append_conn_error(conn, "invalid %s value: \"%s\"", > > + "load_

Re: Make message strings in fe-connect.c consistent

2023-04-20 Thread Tom Lane
Gurjeet Singh writes: > When reviewing a recently committed patch [1] I noticed the odd usage > of a format specifier: > + libpq_append_conn_error(conn, "invalid %s value: \"%s\"", > + "load_balance_hosts", > + conn->lo