Re: Logical replication - schema change not invalidating the relation cache

2023-01-06 Thread Tom Lane
vignesh C writes: > On Fri, 6 Jan 2023 at 04:32, Tom Lane wrote: >> Hm. I spent some time cleaning up this patch, and found that there's >> still a problem. ISTM that the row with value "3" ought to end up >> in the subscriber's sch2.t1 table, but it does not: the attached >> test script fails

Re: Logical replication - schema change not invalidating the relation cache

2023-01-05 Thread vignesh C
On Fri, 6 Jan 2023 at 04:32, Tom Lane wrote: > > vignesh C writes: > > On Thu, 5 Jan 2023 at 03:17, Tom Lane wrote: > >> The bigger picture here though is that in examples such as the one > >> you gave at the top of the thread, it's not very clear to me that > >> there's *any* principled behavio

Re: Logical replication - schema change not invalidating the relation cache

2023-01-05 Thread Tom Lane
vignesh C writes: > On Thu, 5 Jan 2023 at 03:17, Tom Lane wrote: >> The bigger picture here though is that in examples such as the one >> you gave at the top of the thread, it's not very clear to me that >> there's *any* principled behavior. If the connection between publisher >> and subscriber

Re: Logical replication - schema change not invalidating the relation cache

2023-01-05 Thread vignesh C
On Thu, 5 Jan 2023 at 03:17, Tom Lane wrote: > > vignesh C writes: > > [ v3-0001-Fix-for-invalidating-logical-replication-relation.patch ] > > (btw, please don't send multiple patch versions with the same number, > it's very confusing.) Since it was just rebasing on top of HEAD, I did not change

Re: Logical replication - schema change not invalidating the relation cache

2023-01-04 Thread Tom Lane
vignesh C writes: > [ v3-0001-Fix-for-invalidating-logical-replication-relation.patch ] (btw, please don't send multiple patch versions with the same number, it's very confusing.) I looked briefly at this patch. I wonder why you wrote a whole new callback function instead of just using rel_sync

Re: Logical replication - schema change not invalidating the relation cache

2022-08-07 Thread vignesh C
On Sat, Mar 12, 2022 at 1:29 PM vignesh C wrote: > > On Fri, Dec 3, 2021 at 3:21 PM vignesh C wrote: > > > > On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote: > > > > > > On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote: > > > > The previous patch was failing because of the recent t

Re: Logical replication - schema change not invalidating the relation cache

2022-03-11 Thread vignesh C
On Fri, Dec 3, 2021 at 3:21 PM vignesh C wrote: > > On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote: > > > > On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote: > > > The previous patch was failing because of the recent test changes made > > > by commit 201a76183e2 which unified new a

Re: Logical replication - schema change not invalidating the relation cache

2021-12-03 Thread vignesh C
On Fri, Dec 3, 2021 at 1:13 PM Michael Paquier wrote: > > On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote: > > The previous patch was failing because of the recent test changes made > > by commit 201a76183e2 which unified new and get_new_node, attached > > patch has the changes to handle

Re: Logical replication - schema change not invalidating the relation cache

2021-12-02 Thread Michael Paquier
On Thu, Aug 26, 2021 at 09:00:39PM +0530, vignesh C wrote: > The previous patch was failing because of the recent test changes made > by commit 201a76183e2 which unified new and get_new_node, attached > patch has the changes to handle the changes accordingly. Please note that the CF app is complai

Re: Logical replication - schema change not invalidating the relation cache

2021-08-26 Thread vignesh C
On Fri, Jul 16, 2021 at 10:51 PM vignesh C wrote: > > On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > > > Yeah, this looks like a bug. I will look at the patch. > > > > > > > While looking into this, I think the main cause of

Re: Logical replication - schema change not invalidating the relation cache

2021-07-16 Thread vignesh C
On Sat, Jul 3, 2021 at 11:23 AM Dilip Kumar wrote: > > On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > > > Yeah, this looks like a bug. I will look at the patch. > > > > While looking into this, I think the main cause of the problem is that > schema rename does not invalidate the relation

Re: Logical replication - schema change not invalidating the relation cache

2021-07-02 Thread Dilip Kumar
On Fri, Jul 2, 2021 at 12:03 PM Dilip Kumar wrote: > > Yeah, this looks like a bug. I will look at the patch. > While looking into this, I think the main cause of the problem is that schema rename does not invalidate the relation cache right? I also tried other cases e.g. if there is an open cu

Re: Logical replication - schema change not invalidating the relation cache

2021-07-01 Thread Dilip Kumar
On Fri, Jul 2, 2021 at 11:11 AM vignesh C wrote: > > Hi, > > I found a strange behavior when there is an insert after renaming the > schema. The test steps for the same are given below, Here after the > schema is renamed, the renamed schema table data should not be sent, > but the data was being s