Re: Logical decoding for operations on zheap tables

2019-01-21 Thread Dilip Kumar
On Sat, Jan 12, 2019 at 5:02 PM Amit Kapila wrote: > > Fair enough. I think that for now (and maybe for the first version > that can be committed) we might want to use heap tuple format. There > will be some overhead but I think code-wise, things will be simpler. > I have prototyped it for Inser

Re: Logical decoding for operations on zheap tables

2019-01-12 Thread Amit Kapila
On Fri, Jan 4, 2019 at 9:01 AM Andres Freund wrote: > > On 2019-01-04 08:54:34 +0530, Amit Kapila wrote: > > The only point for exposing a different tuple format via plugin was a > > performance which I think can be addressed if we expose via slots. I > > don't want to take up exposing slots inst

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Andres Freund
Hi, On 2019-01-04 08:54:34 +0530, Amit Kapila wrote: > On Thu, Jan 3, 2019 at 11:30 PM Andres Freund wrote: > > On 2018-12-31 09:56:48 +0530, Amit Kapila wrote: > > > To support logical decoding for zheap operations, we need a way to > > > ensure zheap tuples can be registered as change streams.

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Amit Kapila
On Thu, Jan 3, 2019 at 11:30 PM Andres Freund wrote: > > Hi, > > On 2018-12-31 09:56:48 +0530, Amit Kapila wrote: > > To support logical decoding for zheap operations, we need a way to > > ensure zheap tuples can be registered as change streams. One idea > > could be that we make ReorderBufferCh

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Alvaro Herrera
On 2019-Jan-03, Andres Freund wrote: > Hi, > > On 2019-01-03 15:13:42 -0300, Alvaro Herrera wrote: > > Hmm, without looking at the patches, I agree that the tuples should be > > given as slots to the logical decoding interface. I wonder if we need a > > further function in the TTS interface to

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Andres Freund
Hi, On 2019-01-03 15:13:42 -0300, Alvaro Herrera wrote: > On 2019-Jan-03, Andres Freund wrote: > > > > Apart from this, we need to define different decode functions for > > > zheap operations as the WAL data is different for heap and zheap, so > > > same functions can't be used to decode. > > >

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Alvaro Herrera
On 2019-Jan-03, Andres Freund wrote: > > Apart from this, we need to define different decode functions for > > zheap operations as the WAL data is different for heap and zheap, so > > same functions can't be used to decode. > > I'm very strongly opposed to that. We shouldn't have expose every > p

Re: Logical decoding for operations on zheap tables

2019-01-03 Thread Andres Freund
Hi, On 2018-12-31 09:56:48 +0530, Amit Kapila wrote: > To support logical decoding for zheap operations, we need a way to > ensure zheap tuples can be registered as change streams. One idea > could be that we make ReorderBufferChange aware of another kind of > tuples as well, something like this

Re: Logical decoding for operations on zheap tables

2019-01-02 Thread Amit Kapila
On Mon, Dec 31, 2018 at 9:56 AM Amit Kapila wrote: > > To support logical decoding for zheap operations, we need a way to > ensure zheap tuples can be registered as change streams. One idea > could be that we make ReorderBufferChange aware of another kind of > tuples as well, something like this