Re: [SPAM] Re: Local partitioned indexes and pageinspect

2018-05-09 Thread Peter Geoghegan
On Wed, May 9, 2018 at 2:04 PM, Michael Paquier wrote: > On Wed, May 09, 2018 at 02:28:50PM -0300, Alvaro Herrera wrote: >> I pushed some fixes produced here. Attached is the remainder of the >> patch you submitted. I notice now that we haven't actually fixed >> Peter's source of complaint, thou

Re: [SPAM] Re: Local partitioned indexes and pageinspect

2018-05-09 Thread Michael Paquier
On Wed, May 09, 2018 at 02:28:50PM -0300, Alvaro Herrera wrote: > I pushed some fixes produced here. Attached is the remainder of the > patch you submitted. I notice now that we haven't actually fixed > Peter's source of complaint, though. AFAICS your patch just adds test > cases, and upthread d

Re: [SPAM] Re: Local partitioned indexes and pageinspect

2018-05-09 Thread Alvaro Herrera
Michael Paquier wrote: > On Wed, May 02, 2018 at 01:38:22PM +0900, Amit Langote wrote: > > Perhaps, I'm just repeating what's already been said, but I think it might > > be better to have the word "partitioned" in the message. > > That's what Peter is pointing to upthread and what the v1 of upthre

Re: [SPAM] Re: Local partitioned indexes and pageinspect

2018-05-01 Thread Michael Paquier
On Wed, May 02, 2018 at 01:38:22PM +0900, Amit Langote wrote: > Perhaps, I'm just repeating what's already been said, but I think it might > be better to have the word "partitioned" in the message. That's what Peter is pointing to upthread and what the v1 of upthread was doing. I would tend to th

Re: Local partitioned indexes and pageinspect

2018-05-01 Thread Amit Langote
On 2018/05/02 13:38, Amit Langote wrote: > --- a/contrib/amcheck/expected/check_btree.out > +++ b/contrib/amcheck/expected/check_btree.out > > +-- verify partitioned tables are rejected (error) > +SELECT bt_index_check('bttest_partitioned'); > +ERROR: "bttest_partitioned" is not an index > > Per

Re: [SPAM] Re: Local partitioned indexes and pageinspect

2018-05-01 Thread Amit Langote
Hi. On 2018/05/02 11:05, Michael Paquier wrote: > On Tue, May 01, 2018 at 12:30:44PM -0400, Robert Haas wrote: >> However, backing up a minute, I don't think "relation \"%s\" is not a >> btree index" is such a terrible message. These modules are intended >> to be intended by people who Know What

Re: Local partitioned indexes and pageinspect

2018-05-01 Thread Michael Paquier
On Tue, May 01, 2018 at 12:30:44PM -0400, Robert Haas wrote: > That's probably going to cause some translation problems. The form of > "a" that you need will vary: "a" vs. "an" in English, "un" vs. "una" > in Spanish, etc. And it wouldn't be surprising if there are problems > in some languages ev

Re: Local partitioned indexes and pageinspect

2018-05-01 Thread Robert Haas
On Mon, Apr 30, 2018 at 2:50 AM, Michael Paquier wrote: > On Sun, Apr 29, 2018 at 06:20:02PM -0700, Peter Geoghegan wrote: >> What about amcheck? I did change the example query in the docs to >> account for this, so anyone that generalizes from that won't have a >> problem, but it would be nice if

Re: Local partitioned indexes and pageinspect

2018-04-29 Thread Michael Paquier
On Sun, Apr 29, 2018 at 06:20:02PM -0700, Peter Geoghegan wrote: > What about amcheck? I did change the example query in the docs to > account for this, so anyone that generalizes from that won't have a > problem, but it would be nice if it had a friendlier message. I didn't > change amcheck to acc

Re: Local partitioned indexes and pageinspect

2018-04-29 Thread Peter Geoghegan
On Mon, Apr 23, 2018 at 9:58 PM, Michael Paquier wrote: > Hm, the docs about taking backups with the low-level APIs don't care > much about relkind now: > https://www.postgresql.org/docs/devel/static/continuous-archiving.html#BACKUP-LOWLEVEL-BASE-BACKUP > Or do you have another section in the docs

Re: Local partitioned indexes and pageinspect

2018-04-23 Thread Michael Paquier
On Mon, Apr 23, 2018 at 05:29:59PM -0700, Peter Geoghegan wrote: > It looks like local partitioned indexes are a problem for pageinspect: > > pg@regression[28736]=# select bt_metap('at_partitioned_b_idx'); > ERROR: relation "at_partitioned_b_idx" is not a btree index Okay, I can see the point yo