Re: It is not documented that pg_promote can exit standby mode

2020-04-20 Thread Fujii Masao
On 2020/04/20 20:38, Fujii Masao wrote: On 2020/04/18 2:46, Tom Lane wrote: Fujii Masao writes: Thanks for the report and the patch! It looks good to me. Barring any objection, I will commit this patch. It might be worth writing "pg_promote() is called" (adding parentheses) to make it c

Re: It is not documented that pg_promote can exit standby mode

2020-04-20 Thread Fujii Masao
On 2020/04/18 2:46, Tom Lane wrote: Fujii Masao writes: Thanks for the report and the patch! It looks good to me. Barring any objection, I will commit this patch. It might be worth writing "pg_promote() is called" (adding parentheses) to make it clearer that a function is being referred to.

Re: It is not documented that pg_promote can exit standby mode

2020-04-17 Thread Tom Lane
Fujii Masao writes: > Thanks for the report and the patch! It looks good to me. > Barring any objection, I will commit this patch. It might be worth writing "pg_promote() is called" (adding parentheses) to make it clearer that a function is being referred to. No objection otherwise.

Re: It is not documented that pg_promote can exit standby mode

2020-04-17 Thread Laurenz Albe
On Fri, 2020-04-17 at 13:54 +0900, Michael Paquier wrote: > On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote: > > Thanks for the report and the patch! It looks good to me. > > Barring any objection, I will commit this patch. > > +1. +1. That was my omission in the original patch. You

Re: It is not documented that pg_promote can exit standby mode

2020-04-16 Thread Michael Paquier
On Fri, Apr 17, 2020 at 01:40:02PM +0900, Fujii Masao wrote: > Thanks for the report and the patch! It looks good to me. > Barring any objection, I will commit this patch. +1. -- Michael signature.asc Description: PGP signature

Re: It is not documented that pg_promote can exit standby mode

2020-04-16 Thread Fujii Masao
On 2020/04/17 13:11, ikedamsh wrote: Hi, The document(high-availability.sgml) says that there are only two ways to exit standby mode.  26.2.2. Standby Server Operation  Standby mode is exited and the server switches to normal operation when pg_ctl promote is run or a trigger file is found