Re: Is ParsePrepareRecord dead function

2019-07-29 Thread vignesh C
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera wrote: > > On 2019-Jul-29, vignesh C wrote: > > > On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote: > > > > > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote: > > > > I could not locate the caller of ParsePrepareRecord function in > > > > twopha

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread Michael Paquier
On Tue, Jul 30, 2019 at 08:42:06AM +0530, Amit Kapila wrote: > Okay, can you point to that patch? Here you go: https://commitfest.postgresql.org/23/2105/ The thread is mostly waiting after Fujii-san for an update. -- Michael signature.asc Description: PGP signature

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread Alvaro Herrera
On 2019-Jul-30, Amit Kapila wrote: > On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera > wrote: > > I think there's a patch from Fujii Masao that touches that? Might be > > premature to remove it. > > Okay, can you point to that patch? https://postgr.es/m/cahgqgwfqgrwmoorfboohxy1vdgm-ykwdwvwr_b

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread Amit Kapila
On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera wrote: > > On 2019-Jul-29, vignesh C wrote: > > > On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote: > > > > > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote: > > > > I could not locate the caller of ParsePrepareRecord function in > > > > twopha

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread Alvaro Herrera
On 2019-Jul-29, vignesh C wrote: > On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote: > > > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote: > > > I could not locate the caller of ParsePrepareRecord function in > > > twophase.c. > > > Any idea how it gets called? > > > or > > > Is it a dead f

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread vignesh C
On Mon, Jul 29, 2019 at 8:24 PM Robert Haas wrote: > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote: > > I could not locate the caller of ParsePrepareRecord function in twophase.c. > > Any idea how it gets called? > > or > > Is it a dead function? > > It looks like it's not only dead, but stil

Re: Is ParsePrepareRecord dead function

2019-07-29 Thread Robert Haas
On Mon, Jul 29, 2019 at 4:10 AM vignesh C wrote: > I could not locate the caller of ParsePrepareRecord function in twophase.c. > Any idea how it gets called? > or > Is it a dead function? It looks like it's not only dead, but stillborn. Commit 1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced