On Wed, Sep 24, 2025 at 12:11 AM Álvaro Herrera wrote:
>
> Hello,
>
>
> > /*
> > - * Check whether the passed slot name is valid and report errors at elevel.
> > + * Check whether the passed slot name is valid and report errors.
> > + *
> > + * When called from a GUC check hook, elevel must be 0.
On Fri, Sep 19, 2025 at 12:00 PM Fujii Masao wrote:
>
> So I agree it's safer to free them explicitly. In the attached updated patch,
> ReplicationSlotValidateName() now pfrees err_msg and err_hint when needed.
>
+error:
+ if (elevel == 0)
+ {
+ GUC_check_errdetail("%s", err_msg);
+ if (err_hint
On Fri, Sep 19, 2025 at 8:21 AM Chao Li wrote:
>
>
>
> On Sep 19, 2025, at 00:48, Fujii Masao wrote:
>
> Fujii Masao
>
>
>
> ```
> +error:
> + if (elevel == 0)
> + {
> + GUC_check_errdetail("%s", err_msg);
> + if (err_hint != NULL)
> + GUC_check_errhint("%s", err_hint);
> + }
> + else
> + erepor
> On Sep 19, 2025, at 00:48, Fujii Masao wrote:
>
> Fujii Masao
>
```
+error:
+ if (elevel == 0)
+ {
+ GUC_check_errdetail("%s", err_msg);
+ if (err_hint != NULL)
+ GUC_check_errhint("%s", err_hint);
+ }
+ else
+
On Thu, Sep 18, 2025 at 10:54 PM Fujii Masao wrote:
>
> On Fri, Sep 12, 2025 at 9:12 PM Fujii Masao wrote:
> >
> > Hi,
> >
> > While reviewing the patch at [1], I noticed that if primary_slot_name is
> > set to an invalid slot name in postgresql.conf and the configuration file
> > is reloaded, al
On Fri, Sep 12, 2025 at 9:12 PM Fujii Masao wrote:
>
> Hi,
>
> While reviewing the patch at [1], I noticed that if primary_slot_name is
> set to an invalid slot name in postgresql.conf and the configuration file
> is reloaded, all running postgres processes emit the WARNING message
> as follows. I
