Re: InsertPgAttributeTuple() and attcacheoff

2018-08-17 Thread Peter Eisentraut
On 14/08/2018 17:52, Robert Haas wrote: > On Tue, Aug 14, 2018 at 3:50 PM, Tom Lane wrote: >> Peter Eisentraut writes: >>> It seems to me that it would make sense if InsertPgAttributeTuple() were >>> to set attcacheoff to -1 instead of taking it from the caller. >> >> Looked this over, no objecti

Re: InsertPgAttributeTuple() and attcacheoff

2018-08-14 Thread Robert Haas
On Tue, Aug 14, 2018 at 3:50 PM, Tom Lane wrote: > Peter Eisentraut writes: >> It seems to me that it would make sense if InsertPgAttributeTuple() were >> to set attcacheoff to -1 instead of taking it from the caller. > > Looked this over, no objections. > > I wonder whether we should set that fi

Re: InsertPgAttributeTuple() and attcacheoff

2018-08-14 Thread Tom Lane
Peter Eisentraut writes: > It seems to me that it would make sense if InsertPgAttributeTuple() were > to set attcacheoff to -1 instead of taking it from the caller. Looked this over, no objections. I wonder whether we should set that field to -1 when we *read* pg_attribute rows from disk, and be