On Wed, May 26, 2021 at 11:10:22AM +0900, Michael Paquier wrote:
> There is one point where you are right here: log_lock_waits has no
> need to be changed. Looks like I checked too many things at once.
Fixed that, did one extra round of review, and applied.
--
Michael
signature.asc
Description:
On Tue, May 25, 2021 at 09:01:30PM -0500, Justin Pryzby wrote:
> On Tue, May 25, 2021 at 08:43:14PM -0500, Justin Pryzby wrote:
>> Your patch adds documentation about GUCs that can only be set at server
>> start/config/commandline.
>
> Oh: I realized that I read too quickly and misinterpretted wha
On Tue, May 25, 2021 at 08:43:14PM -0500, Justin Pryzby wrote:
> Your patch adds documentation about GUCs that can only be set at server
> start/config/commandline.
Oh: I realized that I read too quickly and misinterpretted what "only be set in
the config" means (I know I'm not the only one). Oop
Your patch adds documentation about GUCs that can only be set at server
start/config/commandline.
But it's not true for any of these, which are all HUP/SUSET.
Please double check your logic :)
src/backend/utils/misc/guc.c: {"autovacuum_work_mem", PGC_SIGHUP,
RESOURCES_MEM,
src/backend/