Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread John Naylor
On Thu, Apr 14, 2022 at 5:03 AM David G. Johnston wrote: > I would be on board with having the language of the entire section written > with the assumption that autovacuum is enabled, with a single statement > upfront that this is the case. Most of the content remains as-is but we > remove a

Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread David G. Johnston
On Wed, Apr 13, 2022 at 2:19 PM Peter Geoghegan wrote: > On Wed, Apr 13, 2022 at 1:25 PM Robert Haas wrote: > > On Wed, Apr 13, 2022 at 12:34 PM Peter Geoghegan wrote: > > > What do you think of the idea of relating freezing to removing tuples > > > by VACUUM at this point? This would be a basi

Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread Peter Geoghegan
On Wed, Apr 13, 2022 at 1:25 PM Robert Haas wrote: > On Wed, Apr 13, 2022 at 12:34 PM Peter Geoghegan wrote: > > What do you think of the idea of relating freezing to removing tuples > > by VACUUM at this point? This would be a basis for explaining how > > freezing and tuple removal are constrain

Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread Robert Haas
On Wed, Apr 13, 2022 at 12:34 PM Peter Geoghegan wrote: > What do you think of the idea of relating freezing to removing tuples > by VACUUM at this point? This would be a basis for explaining how > freezing and tuple removal are constrained by the same cutoff. A very > old snapshot can hold up cle

Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread Peter Geoghegan
On Wed, Apr 13, 2022 at 8:40 AM Robert Haas wrote: > > Something along the lines of the following seems more useful: "A tuple > > whose xmin is frozen (and xmax is unset) is considered visible to > > every possible MVCC snapshot. In other words, the transaction that > > inserted the tuple is treat

Re: Improving the "Routine Vacuuming" docs

2022-04-13 Thread Robert Haas
On Tue, Apr 12, 2022 at 5:53 PM Peter Geoghegan wrote: > My high level concerns are: > > * Instead of discussing FrozenTransactionId (and then explaining how > that particular magic value is not really used anymore anyway), why > not describe freezing in terms of the high level rules? > > Somethin

Re: Improving the "Routine Vacuuming" docs

2022-04-12 Thread David G. Johnston
On Tue, Apr 12, 2022 at 5:22 PM Peter Geoghegan wrote: > I just don't think that you need to make it any more complicated than > this: physical XID values are only meaningful when compared to other > XIDs from the same cluster. The system needs to make sure that no two > XIDs can ever be more tha

Re: Improving the "Routine Vacuuming" docs

2022-04-12 Thread Peter Geoghegan
On Tue, Apr 12, 2022 at 4:24 PM David G. Johnston wrote: > I've attached some off-the-cuff thoughts on reworking the first three > paragraphs and the note. > > It's hopefully useful for providing perspective if nothing else. More perspective is definitely helpful. > I'm assuming and caring only

Re: Improving the "Routine Vacuuming" docs

2022-04-12 Thread David G. Johnston
On Tue, Apr 12, 2022 at 2:53 PM Peter Geoghegan wrote: > Recent work on VACUUM and relfrozenxid advancement required that I > update the maintenance.sgml VACUUM documentation ("Routine > Vacuuming"). It was tricky to keep things current, due in part to > certain structural problems. Many of these