Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em seg., 1 de ago. de 2022 às 18:51, Jacob Champion escreveu: > On 5/31/22 11:44, Tomas Vondra wrote: > > I'd argue this is either just noise, and there's no actual difference. > > This could be verified by some sort of statistical testing (e.g. the > > well known t-test). > > Given the conversat

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/31/22 11:44, Tomas Vondra wrote: > I'd argue this is either just noise, and there's no actual difference. > This could be verified by some sort of statistical testing (e.g. the > well known t-test). Given the conversation so far, I'll go ahead and mark this Returned with Feedback. Specificall

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/31/22 16:36, Ranier Vilela wrote: > Em dom., 29 de mai. de 2022 às 17:10, Ranier Vilela > escreveu: > > Em dom., 29 de mai. de 2022 às 15:21, Andres Freund > mailto:and...@anarazel.de>> escreveu: > > On 2022-05-29 18:00:14 +0200, Tomas Vondra wrot

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em dom., 29 de mai. de 2022 às 15:21, Andres Freund escreveu: > On 2022-05-29 18:00:14 +0200, Tomas Vondra wrote: > > Also, there's the question of correctness, and I'd bet Andres is right > > getting snapshot without holding ProcArrayLock is busted. > > Unless there's some actual analysis of thi

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/29/22 19:26, Ranier Vilela wrote: > ... > I redid the benchmark with a better machine: > Intel i7-10510U > RAM 8GB > SSD 512GB > Linux Ubuntu 64 bits > > All files are attached, including the raw data of the results. > I did the calculations as requested. > But a quick average of the 10 bench

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 2022-05-29 18:00:14 +0200, Tomas Vondra wrote: > Also, there's the question of correctness, and I'd bet Andres is right > getting snapshot without holding ProcArrayLock is busted. Unless there's some actual analysis of this by Rainier, I'm just going to ignore this thread going forward. It's po

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em sáb., 28 de mai. de 2022 às 09:35, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > On 5/28/22 02:36, Ranier Vilela wrote: > > Em sex., 27 de mai. de 2022 às 18:22, Andres Freund > > escreveu: > > > > Hi, > > > > On 2022-05-27 10:35:08 -0300, Ranier

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

> On 28 May 2022, at 16:12, Ranier Vilela wrote: > Just because I don't have enough hardware to force GetSnapShotData() doesn't > mean optimizing it won't make a difference. Quoting Andres from upthread: "To improve something like GetSnapshotData() you first have to come up with a wor

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em sáb., 28 de mai. de 2022 às 09:00, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > On 5/28/22 02:15, Ranier Vilela wrote: > > > > > > Em sex., 27 de mai. de 2022 às 18:08, Andres Freund > > escreveu: > > > > Hi, > > > > On 2022-05-27 03:30:46 +0200,

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/28/22 02:36, Ranier Vilela wrote: > Em sex., 27 de mai. de 2022 às 18:22, Andres Freund > escreveu: > > Hi, > > On 2022-05-27 10:35:08 -0300, Ranier Vilela wrote: > > Em qui., 26 de mai. de 2022 às 22:30, Tomas Vondra < > > tomas.von...@enterprised

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/28/22 02:15, Ranier Vilela wrote: > > > Em sex., 27 de mai. de 2022 às 18:08, Andres Freund > escreveu: > > Hi, > > On 2022-05-27 03:30:46 +0200, Tomas Vondra wrote: > > On 5/27/22 02:11, Ranier Vilela wrote: > > > ./pgbench -M prepared -c $conns

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em sex., 27 de mai. de 2022 às 18:22, Andres Freund escreveu: > Hi, > > On 2022-05-27 10:35:08 -0300, Ranier Vilela wrote: > > Em qui., 26 de mai. de 2022 às 22:30, Tomas Vondra < > > tomas.von...@enterprisedb.com> escreveu: > > > > > On 5/27/22 02:11, Ranier Vilela wrote: > > > > > > > > ... > >

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em sex., 27 de mai. de 2022 às 18:08, Andres Freund escreveu: > Hi, > > On 2022-05-27 03:30:46 +0200, Tomas Vondra wrote: > > On 5/27/22 02:11, Ranier Vilela wrote: > > > ./pgbench -M prepared -c $conns -j $conns -T 60 -S -n -U postgres > > > > > > pgbench (15beta1) > > > transaction type: > > >

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Hi, On 2022-05-27 10:35:08 -0300, Ranier Vilela wrote: > Em qui., 26 de mai. de 2022 às 22:30, Tomas Vondra < > tomas.von...@enterprisedb.com> escreveu: > > > On 5/27/22 02:11, Ranier Vilela wrote: > > > > > > ... > > > > > > Here the results with -T 60: > > > > Might be a good idea to share your

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Hi, On 2022-05-27 03:30:46 +0200, Tomas Vondra wrote: > On 5/27/22 02:11, Ranier Vilela wrote: > > ./pgbench -M prepared -c $conns -j $conns -T 60 -S -n -U postgres > > > > pgbench (15beta1) > > transaction type: > > scaling factor: 1 > > query mode: prepared > > number of clients: 100 > > numbe

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qui., 26 de mai. de 2022 às 22:30, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > On 5/27/22 02:11, Ranier Vilela wrote: > > > > ... > > > > Here the results with -T 60: > > Might be a good idea to share your analysis / interpretation of the > results, not just the raw data. After al

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/27/22 02:11, Ranier Vilela wrote: > > ... > > Here the results with -T 60: Might be a good idea to share your analysis / interpretation of the results, not just the raw data. After all, the change is being proposed by you, so do you think this shows the change is beneficial? > Linux Ubuntu

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 08:26, Ranier Vilela escreveu: > Em qua., 25 de mai. de 2022 às 07:13, Tomas Vondra < > tomas.von...@enterprisedb.com> escreveu: > >> >> >> On 5/25/22 11:07, Ranier Vilela wrote: >> > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > >

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 07:13, Tomas Vondra < tomas.von...@enterprisedb.com> escreveu: > > > On 5/25/22 11:07, Ranier Vilela wrote: > > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > > escreveu: > > > > Hi Andres, thank you for taking a look. > > > > > >

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On 5/25/22 11:07, Ranier Vilela wrote: > Em qua., 25 de mai. de 2022 às 00:46, Andres Freund > escreveu: > > Hi Andres, thank you for taking a look. > > > On 2022-05-24 12:28:20 -0300, Ranier Vilela wrote: > > Linux Ubuntu 64 bits (gcc 9.4) > > ./pgbenc

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 00:56, Andres Freund escreveu: > Hi, > > On 2022-05-24 13:23:43 -0300, Ranier Vilela wrote: > > It certainly helps, but I trust that's not the only reason, in all the > > tests I did, there was an improvement in performance, even before using > > this feature. > > I

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em qua., 25 de mai. de 2022 às 00:46, Andres Freund escreveu: Hi Andres, thank you for taking a look. > > On 2022-05-24 12:28:20 -0300, Ranier Vilela wrote: > > Linux Ubuntu 64 bits (gcc 9.4) > > ./pgbench -M prepared -c $conns -j $conns -S -n -U postgres > > > > conns tps head

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Hi, On 2022-05-24 13:23:43 -0300, Ranier Vilela wrote: > It certainly helps, but I trust that's not the only reason, in all the > tests I did, there was an improvement in performance, even before using > this feature. > If you look closely at GetSnapShotData() you will see that > GetSnapshotDataRe

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Hi, On 2022-05-24 12:28:20 -0300, Ranier Vilela wrote: > Linux Ubuntu 64 bits (gcc 9.4) > ./pgbench -M prepared -c $conns -j $conns -S -n -U postgres > > conns tps head tps patched > 1 2918.004085 3190.810466 > 10 12262.41569617199.8

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

Em ter., 24 de mai. de 2022 às 13:06, Robert Haas escreveu: > On Tue, May 24, 2022 at 11:28 AM Ranier Vilela > wrote: > > I think that I got something. > > You might have something, but it's pretty hard to tell based on > looking at this patch. Whatever relevant changes it has are mixed with > a

Re: Improving connection scalability (src/backend/storage/ipc/procarray.c)

On Tue, May 24, 2022 at 11:28 AM Ranier Vilela wrote: > I think that I got something. You might have something, but it's pretty hard to tell based on looking at this patch. Whatever relevant changes it has are mixed with a bunch of changes that are probably not relevant. For example, it's hard to