Re: Improve tab completion for COPY

2025-07-11 Thread Atsushi Torikoshi
On Wed, Jul 9, 2025 at 10:09 PM Masahiko Sawada wrote: > Thank you for reviewing the patches. I've just pushed the fix. Thanks for pushing them!

Re: Improve tab completion for COPY

2025-07-09 Thread Masahiko Sawada
On Thu, Jul 3, 2025 at 10:30 PM torikoshia wrote: > > On 2025-07-03 11:37, Masahiko Sawada wrote: > > On Wed, Jul 2, 2025 at 2:46 PM torikoshia > > wrote: > >> > >> On 2025-07-01 14:20, Masahiko Sawada wrote: > >> > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada > >> > wrote: > >> >> > >> >> On

Re: Improve tab completion for COPY

2025-07-03 Thread torikoshia
On 2025-07-03 11:37, Masahiko Sawada wrote: On Wed, Jul 2, 2025 at 2:46 PM torikoshia wrote: On 2025-07-01 14:20, Masahiko Sawada wrote: > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada > wrote: >> >> On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart >> wrote: >> > >> > On Tue, Jun 10, 2025 at

Re: Improve tab completion for COPY

2025-07-02 Thread Masahiko Sawada
On Wed, Jul 2, 2025 at 2:46 PM torikoshia wrote: > > On 2025-07-01 14:20, Masahiko Sawada wrote: > > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada > > wrote: > >> > >> On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart > >> wrote: > >> > > >> > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sa

Re: Improve tab completion for COPY

2025-07-01 Thread torikoshia
On 2025-07-01 14:20, Masahiko Sawada wrote: On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada wrote: On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart wrote: > > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: > >> > (1) adds tab completion support for the REJECT_LIMIT option, w

Re: Improve tab completion for COPY

2025-06-30 Thread Masahiko Sawada
On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada wrote: > > On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart > wrote: > > > > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: > > >> > (1) adds tab completion support for the REJECT_LIMIT option, which was > > >> > introduced in v18 >

Re: Improve tab completion for COPY

2025-06-11 Thread Masahiko Sawada
On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart wrote: > > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: > >> > (1) adds tab completion support for the REJECT_LIMIT option, which was > >> > introduced in v18 > >> > (2) splits the tab completion logic between COPY FROM and COPY TO

Re: Improve tab completion for COPY

2025-06-10 Thread Fujii Masao
On 2025/06/11 5:33, Nathan Bossart wrote: On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: (1) adds tab completion support for the REJECT_LIMIT option, which was introduced in v18 (2) splits the tab completion logic between COPY FROM and COPY TO to reflect their different opti

Re: Improve tab completion for COPY

2025-06-10 Thread Nathan Bossart
On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: >> > (1) adds tab completion support for the REJECT_LIMIT option, which was >> > introduced in v18 >> > (2) splits the tab completion logic between COPY FROM and COPY TO to >> > reflect their different options. > > [...] > > Given RE

Re: Improve tab completion for COPY

2025-06-10 Thread Masahiko Sawada
On Mon, Jun 9, 2025 at 7:59 PM Yugo Nagata wrote: > > On Tue, 10 Jun 2025 11:15:09 +0900 > torikoshia wrote: > > > On 2025-06-03 17:58, Yugo Nagata wrote: > > > Thank you for updating the patch. > > > It looks good and I confirmed that this works as expected. > > > > Thanks for your review! > > >

Re: Improve tab completion for COPY

2025-06-09 Thread Yugo Nagata
On Tue, 10 Jun 2025 11:15:09 +0900 torikoshia wrote: > On 2025-06-03 17:58, Yugo Nagata wrote: > > Thank you for updating the patch. > > It looks good and I confirmed that this works as expected. > > Thanks for your review! > > BTW this is a small patch, but it does two things: > > (1) adds ta

Re: Improve tab completion for COPY

2025-06-09 Thread torikoshia
On 2025-06-03 17:58, Yugo Nagata wrote: Thank you for updating the patch. It looks good and I confirmed that this works as expected. Thanks for your review! BTW this is a small patch, but it does two things: (1) adds tab completion support for the REJECT_LIMIT option, which was introduced in

Re: Improve tab completion for COPY

2025-06-03 Thread Yugo Nagata
On Thu, 8 May 2025 21:39:10 +0900 torikoshia wrote: > Thanks for your comments! > > On 2025-05-08 08:53, Yugo Nagata wrote: > > On Wed, 7 May 2025 14:36:35 -0700 > > Masahiko Sawada wrote: > > > >> On Wed, May 7, 2025 at 6:23 AM Yugo Nagata > >> wrote: > >> > > >> > On Wed, 7 May 2025 15:39:

Re: Improve tab completion for COPY

2025-05-08 Thread torikoshia
Thanks for your comments! On 2025-05-08 08:53, Yugo Nagata wrote: On Wed, 7 May 2025 14:36:35 -0700 Masahiko Sawada wrote: On Wed, May 7, 2025 at 6:23 AM Yugo Nagata wrote: > > On Wed, 7 May 2025 15:39:26 +0900 > torikoshia wrote: > > > Hi, > > > > I noticed that REJECT_LIMIT, an option av

Re: Improve tab completion for COPY

2025-05-07 Thread Yugo Nagata
On Wed, 7 May 2025 14:36:35 -0700 Masahiko Sawada wrote: > On Wed, May 7, 2025 at 6:23 AM Yugo Nagata wrote: > > > > On Wed, 7 May 2025 15:39:26 +0900 > > torikoshia wrote: > > > > > Hi, > > > > > > I noticed that REJECT_LIMIT, an option available for COPY FROM, is not > > > currently supported

Re: Improve tab completion for COPY

2025-05-07 Thread Masahiko Sawada
On Wed, May 7, 2025 at 6:23 AM Yugo Nagata wrote: > > On Wed, 7 May 2025 15:39:26 +0900 > torikoshia wrote: > > > Hi, > > > > I noticed that REJECT_LIMIT, an option available for COPY FROM, is not > > currently supported in psql's tab completion. > > > > Additionally, some options are only valid

Re: Improve tab completion for COPY

2025-05-07 Thread Yugo Nagata
On Wed, 7 May 2025 15:39:26 +0900 torikoshia wrote: > Hi, > > I noticed that REJECT_LIMIT, an option available for COPY FROM, is not > currently supported in psql's tab completion. > > Additionally, some options are only valid for COPY FROM or COPY TO, i.e. > FREEZE, ON_ERROR, FORCE_QUOTE, bu