Re: Improve const use in zlib-using code

2023-08-07 Thread Peter Eisentraut
On 03.08.23 16:30, Tristan Partin wrote: Both patches look good to me. committed, thanks

Re: Improve const use in zlib-using code

2023-08-03 Thread Tristan Partin
Both patches look good to me. -- Tristan Partin Neon (https://neon.tech)

Re: Improve const use in zlib-using code

2023-08-03 Thread Peter Eisentraut
On 02.08.23 16:39, Tristan Partin wrote: I like the idea. Though the way you have it implemented at the moment seems like a trap in that any time zlib.h is included someone also has to remember to add this define. I would recommend adding the define to the build systems instead. Ok, moved to

Re: Improve const use in zlib-using code

2023-08-02 Thread Tristan Partin
Peter, I like the idea. Though the way you have it implemented at the moment seems like a trap in that any time zlib.h is included someone also has to remember to add this define. I would recommend adding the define to the build systems instead. Since you put in the work to find the version