Re: Ignoring BRIN for HOT udpates seems broken

2022-06-16 Thread Tomas Vondra
On 6/6/22 09:28, Michael Paquier wrote: > On Mon, Jun 06, 2022 at 09:08:08AM +0200, Tomas Vondra wrote: >> Attached is a patch reverting both commits (5753d4ee32 and fe60b67250). >> This changes the IndexAmRoutine struct, so it's an ABI break. That's not >> great post-beta :-( In principle we might

Re: Ignoring BRIN for HOT udpates seems broken

2022-06-06 Thread Michael Paquier
On Mon, Jun 06, 2022 at 09:08:08AM +0200, Tomas Vondra wrote: > Attached is a patch reverting both commits (5753d4ee32 and fe60b67250). > This changes the IndexAmRoutine struct, so it's an ABI break. That's not > great post-beta :-( In principle we might also leave amhotblocking in > the struct but

Re: Ignoring BRIN for HOT udpates seems broken

2022-06-06 Thread Tomas Vondra
On 6/1/22 22:38, Robert Haas wrote: > On Sat, May 28, 2022 at 4:51 PM Tomas Vondra > wrote: >> Yeah, I think that might/should work. We could still create the HOT >> chain, but we'd have to update the BRIN indexes. But that seems like a >> fairly complicated change to be done this late for PG15. >

Re: Ignoring BRIN for HOT udpates seems broken

2022-06-01 Thread Robert Haas
On Sat, May 28, 2022 at 4:51 PM Tomas Vondra wrote: > Yeah, I think that might/should work. We could still create the HOT > chain, but we'd have to update the BRIN indexes. But that seems like a > fairly complicated change to be done this late for PG15. Yeah, I think a revert is better for now. B

Re: Ignoring BRIN for HOT udpates seems broken

2022-05-30 Thread Andres Freund
Hi, On 2022-05-30 17:22:35 +0200, Matthias van de Meent wrote: > > Yeah, I think that might/should work. We could still create the HOT > > chain, but we'd have to update the BRIN indexes. But that seems like a > > fairly complicated change to be done this late for PG15. > > Here's an example patc

Re: Ignoring BRIN for HOT udpates seems broken

2022-05-30 Thread Matthias van de Meent
On Sat, 28 May 2022 at 22:51, Tomas Vondra wrote: > > > > On 5/28/22 21:24, Matthias van de Meent wrote: > > On Sat, 28 May 2022 at 16:51, Tomas Vondra > > wrote: > >> > >> Hi, > >> > >> while working on some BRIN stuff, I realized (my) commit 5753d4ee320b > >> ignoring BRIN indexes for HOT is li

Re: Ignoring BRIN for HOT udpates seems broken

2022-05-28 Thread Tomas Vondra
On 5/28/22 21:24, Matthias van de Meent wrote: > On Sat, 28 May 2022 at 16:51, Tomas Vondra > wrote: >> >> Hi, >> >> while working on some BRIN stuff, I realized (my) commit 5753d4ee320b >> ignoring BRIN indexes for HOT is likely broken. Consider this example: >> >>

Re: Ignoring BRIN for HOT udpates seems broken

2022-05-28 Thread Matthias van de Meent
On Sat, 28 May 2022 at 16:51, Tomas Vondra wrote: > > Hi, > > while working on some BRIN stuff, I realized (my) commit 5753d4ee320b > ignoring BRIN indexes for HOT is likely broken. Consider this example: > > -- > CREATE TABLE t (