On Wed, Jun 12, 2024 at 9:58 PM Tom Lane wrote:
> We could probably assume that we'll treat their code as though
> HAVE_POSIX_DECLS is true and so this whole stanza goes away.
> But I'd just as soon not think about it until I have the energy
> to do that sync. Unless somebody else is hot to do it
Nathan Bossart writes:
> On Wed, Jun 12, 2024 at 05:59:14PM -0400, Peter Geoghegan wrote:
>> There is also one oddball case, not quite in either category. This
>> involves zic.c's declaration of
>> link(), when it should actually just be using the #include
>> declaration.
> That one seems to be
On Wed, Jun 12, 2024 at 05:59:14PM -0400, Peter Geoghegan wrote:
> There is also one oddball case, not quite in either category. This
> involves zic.c's declaration of
> link(), when it should actually just be using the #include
> declaration. That's another weird upstream code thing -- this isn'
On Wed, Jun 12, 2024 at 5:32 PM Nathan Bossart wrote:
> I would be surprised if this 2-line patch created anything approaching a
> significant amount of work down the road. FWIW commit 10d34fe already
> changed one line in indent.c.
I missed that.
> > I'd like to push this patch now. It's gener
On Wed, Jun 12, 2024 at 5:33 PM Tom Lane wrote:
> Peter Geoghegan writes:
> > Attached patch harmonizes pg_bsd_indent's function parameter names, so
> > that they match the names used in corresponding function definitions.
>
> Hmm, these aren't really harmonizing inconsistencies, but overruling
>
Peter Geoghegan writes:
> Attached patch harmonizes pg_bsd_indent's function parameter names, so
> that they match the names used in corresponding function definitions.
Hmm, these aren't really harmonizing inconsistencies, but overruling
somebody's style decision to leave parameter names out of t
On Wed, Jun 12, 2024 at 05:14:44PM -0400, Peter Geoghegan wrote:
> I have been putting this off because I wasn't sure that the policy
> should be the same for pg_bsd_indent. Is there any reason to think
> that this will create more work down the line? It seems like it might,
> due to some kind of n
