Re: Git revision in tarballs

2021-07-21 Thread Tom Lane
Peter Eisentraut writes: > On 21.07.21 21:12, Daniel Gustafsson wrote: >>> Additionally the commit ID is stored in a global extended >>> pax header if the tar format is used; it can be extracted using git >>> get-tar-commit-id. In ZIP files it is stored as >>> a file comment. >> That does adds Gi

Re: Git revision in tarballs

2021-07-21 Thread Peter Eisentraut
On 21.07.21 21:12, Daniel Gustafsson wrote: Or we could do what git-archive does: Additionally the commit ID is stored in a global extended pax header if the tar format is used; it can be extracted using git get-tar-commit-id. In ZIP files it is stored as a file comment. That d

Re: Git revision in tarballs

2021-07-21 Thread Daniel Gustafsson
> On 21 Jul 2021, at 21:23, Tom Lane wrote: > FYI, the "put it into .gitrevision" solution is already implemented > in the new tarball-building script that Magnus and I have been > working on off-list. +1, I think that's the preferred option. -- Daniel Gustafsson https://vmware.co

Re: Git revision in tarballs

2021-07-21 Thread Tom Lane
Daniel Gustafsson writes: > On 21 Jul 2021, at 20:25, Peter Eisentraut > wrote: >> On 15.07.21 10:33, Magnus Hagander wrote: >>> I think it'd be useful to be able to identify exactly which git commit >>> was used to produce a tarball. >> Or we could do what git-archive does: >> Additionally the

Re: Git revision in tarballs

2021-07-21 Thread Daniel Gustafsson
> On 21 Jul 2021, at 20:25, Peter Eisentraut > wrote: > > On 15.07.21 10:33, Magnus Hagander wrote: >> I think it'd be useful to be able to identify exactly which git commit >> was used to produce a tarball. This would be especially useful when >> downloading snapshot tarballs where that's not e

Re: Git revision in tarballs

2021-07-21 Thread Peter Eisentraut
On 15.07.21 10:33, Magnus Hagander wrote: I think it'd be useful to be able to identify exactly which git commit was used to produce a tarball. This would be especially useful when downloading snapshot tarballs where that's not entirely clear, but can also be used to verify that the release tarba

Re: Git revision in tarballs

2021-07-15 Thread Magnus Hagander
On Thu, Jul 15, 2021 at 4:35 PM Tom Lane wrote: > > Magnus Hagander writes: > > Putting it in the tarball making script certainly works for me, > > though, if that's what people prefer. And that does away with the > > "clean" part as that one blows away the whole directory between each > > run. >

Re: Git revision in tarballs

2021-07-15 Thread Tom Lane
Magnus Hagander writes: > Putting it in the tarball making script certainly works for me, > though, if that's what people prefer. And that does away with the > "clean" part as that one blows away the whole directory between each > run. Actually, we *have* to do it over there, because what that sc

Re: Git revision in tarballs

2021-07-15 Thread Magnus Hagander
On Thu, Jul 15, 2021 at 3:53 PM Tom Lane wrote: > > Magnus Hagander writes: > > On Thu, Jul 15, 2021 at 1:40 PM Josef Šimánek > > wrote: > >> The only problem I do see is adding "git" as a new dependency. That > >> can potentially cause troubles. > > > But only for *creating* the tarballs, and

Re: Git revision in tarballs

2021-07-15 Thread Tom Lane
Magnus Hagander writes: > On Thu, Jul 15, 2021 at 1:40 PM Josef Šimánek wrote: >> The only problem I do see is adding "git" as a new dependency. That >> can potentially cause troubles. > But only for *creating* the tarballs, and not for using them. I'm not > sure what the usecase would be to cr

Re: Git revision in tarballs

2021-07-15 Thread Michael Paquier
On Thu, Jul 15, 2021 at 01:44:45PM +0200, Magnus Hagander wrote: > But only for *creating* the tarballs, and not for using them. I'm not > sure what the usecase would be to create a tarball from an environment > that doesn't have git? Which would likely mean somebody creating a release tarball in

Re: Git revision in tarballs

2021-07-15 Thread Magnus Hagander
On Thu, Jul 15, 2021 at 1:40 PM Josef Šimánek wrote: > > čt 15. 7. 2021 v 10:33 odesílatel Magnus Hagander > napsal: > > > > I think it'd be useful to be able to identify exactly which git commit > > was used to produce a tarball. This would be especially useful when > > downloading snapshot tar

Re: Git revision in tarballs

2021-07-15 Thread Josef Šimánek
čt 15. 7. 2021 v 10:33 odesílatel Magnus Hagander napsal: > > I think it'd be useful to be able to identify exactly which git commit > was used to produce a tarball. This would be especially useful when > downloading snapshot tarballs where that's not entirely clear, but can > also be used to veri