Re: Generating configure from configure.ac

2024-11-25 Thread Noah Misch
On Tue, Nov 26, 2024 at 12:07:59AM -0500, Tom Lane wrote: > It seems plausible to me that the -D_LARGE_FILES=1 settings in our > AIX animals' configuration are carried over from some dim past where > we didn't have this configure test, or it was implemented even less > correctly than now. I wonder

Re: Generating configure from configure.ac

2024-11-25 Thread Tom Lane
Thomas Munro writes: > . o O ( I wonder if that missing Debian/Ubuntu bugfix[1] is why our > AIX animals have -D_LARGE_FILES=1 jammed into $CC, even though > AC_SYS_LARGEFILES claims to understand AIX ) I'm dubious. The two likely results if off_t is 32 bits are (1) the compiler shifts the 1 off

Re: Generating configure from configure.ac

2024-11-25 Thread Thomas Munro
On Tue, Nov 26, 2024 at 2:29 PM Tatsuo Ishii wrote: > -#define LARGE_OFF_T (((off_t) 1 << 62) - 1 + ((off_t) 1 << 62)) > +#define LARGE_OFF_T off_t) 1 << 31) << 31) - 1 + (((off_t) 1 << 31) << > 31)) . o O ( I wonder if that missing Debian/Ubuntu bugfix[1] is why our AIX animals have -D_LARG

Re: Generating configure from configure.ac

2024-11-25 Thread Tom Lane
Tatsuo Ishii writes: > BTW, in my understanding, patch posters do not need to submit a patch > for configure, a patch for configure.ac is enough since configure will > be generated by committers anyway (if the patch gets committed). Right. Even if the submitter includes a diff for configure, it'

Re: Generating configure from configure.ac

2024-11-25 Thread Tatsuo Ishii
> Tatsuo Ishii writes: >> I ran autoconf 2.69 on my Ubuntu 20.04 laptop and got the same diffs >> plus diffs related runstatedir: > >> + --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run] > >> If my understanding is correct, configure in the git repository has >> been gener

Re: Generating configure from configure.ac

2024-11-25 Thread Tom Lane
Tatsuo Ishii writes: > I ran autoconf 2.69 on my Ubuntu 20.04 laptop and got the same diffs > plus diffs related runstatedir: > + --runstatedir=DIR modifiable per-process data [LOCALSTATEDIR/run] > If my understanding is correct, configure in the git repository has > been generated by aut