Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems

2021-04-21 Thread Andrew Dunstan
On 4/20/21 6:49 PM, Alexey Kondratov wrote: > On 2021-04-20 18:03, Tom Lane wrote: >> Andrew Dunstan writes: >>> On 4/19/21 7:22 PM, Tom Lane wrote: I wonder whether we could get away with just replacing the $use_tcp test with $TestLib::windows_os.  It's not really apparent to me

Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems

2021-04-20 Thread Alexey Kondratov
On 2021-04-20 18:03, Tom Lane wrote: Andrew Dunstan writes: On 4/19/21 7:22 PM, Tom Lane wrote: I wonder whether we could get away with just replacing the $use_tcp test with $TestLib::windows_os. It's not really apparent to me why we should care about 127.0.0.not-1 on Unix-oid systems. Yea

Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems

2021-04-20 Thread Tom Lane
Andrew Dunstan writes: > On 4/19/21 7:22 PM, Tom Lane wrote: >> I wonder whether we could get away with just replacing the $use_tcp >> test with $TestLib::windows_os. It's not really apparent to me >> why we should care about 127.0.0.not-1 on Unix-oid systems. > Yeah > The comment is a bit stran

Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems

2021-04-20 Thread Andrew Dunstan
On 4/19/21 7:22 PM, Tom Lane wrote: > Alexey Kondratov writes: >> And this is an absolute true, on BSD-like systems (macOS and FreeBSD >> tested) it hangs on looping through the entire ports range over and over >> when $PostgresNode::use_tcp = 1 is set, since bind fails with: > Hm. > >> That w

Re: Free port choosing freezes when PostgresNode::use_tcp is used on BSD systems

2021-04-19 Thread Tom Lane
Alexey Kondratov writes: > And this is an absolute true, on BSD-like systems (macOS and FreeBSD > tested) it hangs on looping through the entire ports range over and over > when $PostgresNode::use_tcp = 1 is set, since bind fails with: Hm. > That way, if it really could happen why not to just