Re: Force lookahead in COPY FROM parsing

2021-04-06 Thread Heikki Linnakangas
On 02/04/2021 20:21, John Naylor wrote: I have nothing further so it's RFC. The patch is pretty simple compared to the earlier ones, but is worth running the fuzzer again as added insurance? Good idea. I did that, and indeed it revealed bugs. If the client sent just a single byte in one CopyD

Re: Force lookahead in COPY FROM parsing

2021-04-02 Thread John Naylor
On Thu, Apr 1, 2021 at 4:47 PM Heikki Linnakangas wrote: > Ok, I wouldn't expect to see much difference in that test, it gets > drowned in all the other parsing overhead. I tested this now with this: > > copy (select repeat('x', 1) from generate_series(1, 10)) to > '/tmp/copydata-x.txt' >

Re: Force lookahead in COPY FROM parsing

2021-04-01 Thread Heikki Linnakangas
On 18/03/2021 17:09, John Naylor wrote: The cfbot thinks this patch no longer applies, but it works for me, so still set to RFC. It looks like it's because the thread to remove the v2 FE/BE protocol was still attached to the commitfest entry. I've deleted that, so let's see if that helps. It

Re: Force lookahead in COPY FROM parsing

2021-03-18 Thread John Naylor
The cfbot thinks this patch no longer applies, but it works for me, so still set to RFC. It looks like it's because the thread to remove the v2 FE/BE protocol was still attached to the commitfest entry. I've deleted that, so let's see if that helps. To answer the side question of whether it makes

Re: Force lookahead in COPY FROM parsing

2021-03-04 Thread John Naylor
On Thu, Mar 4, 2021 at 5:13 AM Heikki Linnakangas wrote: > > I posted this earlier at > https://www.postgresql.org/message-id/9ec25819-0a8a-d51a-17dc-4150bb3cc...@iki.fi , > and that led to removing FE/BE protocol version 2 support. That's been > committed now, so here's COPY FROM patch again, reb