Re: Forbid the use of invalidated physical slots in streaming replication.

2024-02-01 Thread vignesh C
On Mon, 8 Jan 2024 at 10:25, vignesh C wrote: > > On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat > wrote: > > > > > > > pg_replication_slot could be set back to null. > > > > > > > > In this case, since the basebackup was taken after the slot was > > > > invalidated, it > > > > does not require the

Re: Forbid the use of invalidated physical slots in streaming replication.

2024-01-15 Thread Robert Haas
On Thu, Dec 7, 2023 at 8:00 AM Zhijie Hou (Fujitsu) wrote: > After looking closer, it seems this behavior started from 15f8203 which > introduced the > ReplicationSlotInvalidationCause 'invalidated', after that we check the > invalidated enum > in Xmin/Lsn computation function. Adding Andres in

Re: Forbid the use of invalidated physical slots in streaming replication.

2024-01-07 Thread vignesh C
On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat wrote: > > > > > pg_replication_slot could be set back to null. > > > > > > In this case, since the basebackup was taken after the slot was > > > invalidated, it > > > does not require the WAL that was removed. But it seems that once the > > > streaming

Re: Forbid the use of invalidated physical slots in streaming replication.

2023-12-08 Thread Ashutosh Bapat
> > > pg_replication_slot could be set back to null. > > > > In this case, since the basebackup was taken after the slot was > > invalidated, it > > does not require the WAL that was removed. But it seems that once the > > streaming starts, the slot sprints to life again and gets validated again.

RE: Forbid the use of invalidated physical slots in streaming replication.

2023-12-07 Thread Zhijie Hou (Fujitsu)
On Thursday, December 7, 2023 7:43 PM Ashutosh Bapat wrote: Hi, > > On Wed, Dec 6, 2023 at 6:25 PM Zhijie Hou (Fujitsu) > wrote: > > > > When testing streaming replication with a physical slot. I found an > > unexpected behavior that the walsender could use an invalidated > > physical slot fo

Re: Forbid the use of invalidated physical slots in streaming replication.

2023-12-07 Thread Ashutosh Bapat
On Wed, Dec 6, 2023 at 6:25 PM Zhijie Hou (Fujitsu) wrote: > > Hi, > > When testing streaming replication with a physical slot. I found an unexpected > behavior that the walsender could use an invalidated physical slot for > streaming. > > This occurs when the primary slot is invalidated due to re