Re: Fixup some appendPQExpBuffer() calls

2025-04-18 Thread David Rowley
On Thu, 17 Apr 2025 at 19:50, Daniel Gustafsson wrote: > > On 17 Apr 2025, at 01:44, David Rowley wrote: > > 1) Commit the attached to master > > 2) Do nothing. > > > > I'd like to do #1. > > I vote for #1 as well. Thanks for the judgment sense check. I suspect anyone who thought #2 would have

Re: Fixup some appendPQExpBuffer() calls

2025-04-17 Thread Daniel Gustafsson
> On 17 Apr 2025, at 01:44, David Rowley wrote: > To reduce the above 3 options down to two, I just pushed the ones that > were new to v18. The attached patch handles the ones that were added > prior to v18. > > The options now are: > 1) Commit the attached to master > 2) Do nothing. > > I'd l

Re: Fixup some appendPQExpBuffer() calls

2025-04-16 Thread David Rowley
On Mon, 14 Apr 2025 at 19:39, David Rowley wrote: > 1) I should commit the attached 0002 patch now, or; > 2) Should commit only the new-to-v18 ones now, or; > 3) do nothing. > > I think #3 isn't a good option as we (or I) have made efforts in the > past to keep these in check. Also, for me, #2 isn