Re: Fixing parallel make of libpq

2020-02-23 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > OK, got that. But that doesn't directly answer the question of whether > it's wrong to use a phony target as an order-only prerequisite of > another phony target. Grepping around for other possible issues, > I see that you recently added > > update-unicode: | submake-generate

Re: Fixing parallel make of libpq

2020-01-10 Thread Tom Lane
Peter Eisentraut writes: > On 2020-01-09 15:17, Tom Lane wrote: >> 1) Changing from an "|"-style dependency to a plain dependency seems >> like a semantics change. I've never been totally clear on the >> difference though. I think Peter introduced our use of the "|" style, >> so maybe he can com

Re: Fixing parallel make of libpq

2020-01-10 Thread Peter Eisentraut
On 2020-01-09 15:17, Tom Lane wrote: 1) Changing from an "|"-style dependency to a plain dependency seems like a semantics change. I've never been totally clear on the difference though. I think Peter introduced our use of the "|" style, so maybe he can comment. If you have a phony target as

Re: Fixing parallel make of libpq

2020-01-09 Thread Dagfinn Ilmari Mannsåker
Tom Lane writes: > My thoughts about the patch: > > 1) Changing from an "|"-style dependency to a plain dependency seems > like a semantics change. I've never been totally clear on the > difference though. I think Peter introduced our use of the "|" style, > so maybe he can comment. Makefile.s

Re: Fixing parallel make of libpq

2020-01-09 Thread Tom Lane
ilm...@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Michael Paquier writes: >> Hmm. That logically makes sense. Isn't that a side effect of 7143b3e >> then? Now, FWIW, I am not able to reproduce it here, after trying on >> two different machines, various parallel job numbers

Re: Fixing parallel make of libpq

2020-01-08 Thread Michael Paquier
On Wed, Jan 08, 2020 at 01:33:13PM +, Dagfinn Ilmari Mannsåker wrote: > I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq' > doesn't work in a clean checkout, because it can't find > libpgcommon_shlib and libpgport_shlib. It looks like that's because the > submake-libpgport depe