Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-22 Thread Ranier Vilela
Em seg., 22 de ago. de 2022 às 01:42, Amit Kapila escreveu: > On Sat, Aug 20, 2022 at 10:04 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > Right, but as Tom pointed it is still better to change this. However, > > > I am not sure if we should backpatch this to PG15 as this won't lead > > >

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-21 Thread Amit Kapila
On Sat, Aug 20, 2022 at 10:04 AM Tom Lane wrote: > > Amit Kapila writes: > > Right, but as Tom pointed it is still better to change this. However, > > I am not sure if we should backpatch this to PG15 as this won't lead > > to any incorrect behavior. > > If that code only exists in HEAD and v15 t

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-20 Thread Ranier Vilela
Em sáb., 20 de ago. de 2022 às 01:03, Amit Kapila escreveu: > On Fri, Aug 19, 2022 at 7:45 PM Ranier Vilela wrote: > > > > Em sex., 19 de ago. de 2022 às 10:28, Tom Lane > escreveu: > >> > >> Ranier Vilela writes: > >> > At function parallel_vacuum_process_all_indexes there is > >> > a typo wi

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Tom Lane
Amit Kapila writes: > Right, but as Tom pointed it is still better to change this. However, > I am not sure if we should backpatch this to PG15 as this won't lead > to any incorrect behavior. If that code only exists in HEAD and v15 then I'd backpatch. It's a very low-risk change and it might avo

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Amit Kapila
On Fri, Aug 19, 2022 at 7:45 PM Ranier Vilela wrote: > > Em sex., 19 de ago. de 2022 às 10:28, Tom Lane escreveu: >> >> Ranier Vilela writes: >> > At function parallel_vacuum_process_all_indexes there is >> > a typo with a logical connector. >> > I think that correct is &&, because both of the o

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Ranier Vilela
Em sex., 19 de ago. de 2022 às 10:28, Tom Lane escreveu: > Ranier Vilela writes: > > At function parallel_vacuum_process_all_indexes there is > > a typo with a logical connector. > > I think that correct is &&, because both of the operators are > > bool types [1]. > > As a result, parallel vacuu

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Tom Lane
Ranier Vilela writes: > At function parallel_vacuum_process_all_indexes there is > a typo with a logical connector. > I think that correct is &&, because both of the operators are > bool types [1]. > As a result, parallel vacuum workers can be incorrectly enabled. Since they're bools, the C spec

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Amit Kapila
On Fri, Aug 19, 2022 at 5:40 PM Bharath Rupireddy wrote: > > On Fri, Aug 19, 2022 at 5:35 PM Ranier Vilela wrote: > > > > Hi, > > > > At function parallel_vacuum_process_all_indexes there is > > a typo with a logical connector. > > > > I think that correct is &&, because both of the operators are

Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

2022-08-19 Thread Bharath Rupireddy
On Fri, Aug 19, 2022 at 5:35 PM Ranier Vilela wrote: > > Hi, > > At function parallel_vacuum_process_all_indexes there is > a typo with a logical connector. > > I think that correct is &&, because both of the operators are > bool types [1]. > > As a result, parallel vacuum workers can be incorrect