Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

Thank you for the commit. regards, Ranier Vilela

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

Created a CF entry. https://commitfest.postgresql.org/40/3883/ Attached a patch with a fix correction to regress output. I think this needs to be backpatched until version 12. regards, Ranier Vilela v1-0001-fix-typo-isnan-test-geo_ops.patch Description: Binary data

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

> On 4 Sep 2022, at 14:39, Ranier Vilela wrote: > But with Windows 10 build, I got this diff result: > > diff -w -U3 > C:/dll/postgres_dev/postgres_master/src/test/regress/expected/geometry.out > C:/dll/postgres_dev/postgres_master/src/test/regress/results/geometry.out > --- > C:/dll/postgres

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

Em sáb., 3 de set. de 2022 às 19:39, Daniel Gustafsson escreveu: > > On 3 Sep 2022, at 09:36, Julien Rouhaud wrote: > > > Yeah, there are unfortunately a lot of problems around those and NaN, > with > > multiple reports in the past (I recall [1] and [2] but there were > others). > > NaNs are ind

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

> On 3 Sep 2022, at 09:36, Julien Rouhaud wrote: > Yeah, there are unfortunately a lot of problems around those and NaN, with > multiple reports in the past (I recall [1] and [2] but there were others). NaNs are indeed incredibly complicated, but I think we are sort of in a good place here given

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

Hi, On Fri, Sep 01, 2022 at 09:55:15PM +0200, Daniel Gustafsson wrote: > > On 2 Sep 2022, at 21:22, Ranier Vilela wrote: > > > > Em sex., 2 de set. de 2022 às 16:15, Daniel Gustafsson > > escreveu: > > > On 2 Sep 2022, at 21:08, Ranier Vilela > >

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

> On 2 Sep 2022, at 21:22, Ranier Vilela wrote: > > Em sex., 2 de set. de 2022 às 16:15, Daniel Gustafsson > escreveu: > > On 2 Sep 2022, at 21:08, Ranier Vilela > > wrote: > > > At function circle_same the second isnan test is wrong. > > Ye

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

Em sex., 2 de set. de 2022 às 16:15, Daniel Gustafsson escreveu: > > On 2 Sep 2022, at 21:08, Ranier Vilela wrote: > > > At function circle_same the second isnan test is wrong. > > Yeah, that seems pretty wrong. Did you attempt to procure a test for when > this > yields the wrong result? > Hi D

Re: Fix typo function circle_same (src/backend/utils/adt/geo_ops.c)

> On 2 Sep 2022, at 21:08, Ranier Vilela wrote: > At function circle_same the second isnan test is wrong. Yeah, that seems pretty wrong. Did you attempt to procure a test for when this yields the wrong result? -- Daniel Gustafsson https://vmware.com/