On 2020-Dec-22, Tomas Vondra wrote:
> Thanks. I started looking at this a bit more closely, and I think most of
> the changes are fine - the code was changed to call a different function,
> but the comments still reference generate_gather_paths().
Hi, this was forgotten. It seemed better to fix
Hi,
On Mon, Feb 1, 2021 at 11:44 AM Masahiko Sawada wrote:
>
> Hi,
>
> On Wed, Dec 23, 2020 at 3:24 AM Tomas Vondra
> wrote:
> >
> > On 12/9/20 3:21 AM, Hou, Zhijie wrote:
> > > Hi
> > >
> > > Since ba3e76c,
> > > the optimizer call generate_useful_gather_paths instead of
> > > generate_gather_
Hi,
On Wed, Dec 23, 2020 at 3:24 AM Tomas Vondra
wrote:
>
> On 12/9/20 3:21 AM, Hou, Zhijie wrote:
> > Hi
> >
> > Since ba3e76c,
> > the optimizer call generate_useful_gather_paths instead of
> > generate_gather_paths() outside.
> >
> > But I noticed that some comment still talking about generat
On 12/9/20 3:21 AM, Hou, Zhijie wrote:
Hi
Since ba3e76c,
the optimizer call generate_useful_gather_paths instead of
generate_gather_paths() outside.
But I noticed that some comment still talking about generate_gather_paths not
generate_useful_gather_paths.
I think we should fix these comment,