Re: Fix memory counter update in reorderbuffer

2024-08-26 Thread Masahiko Sawada
On Mon, Aug 26, 2024 at 2:27 PM Nathan Bossart wrote: > > On Mon, Aug 26, 2024 at 11:25:53AM -0700, Masahiko Sawada wrote: > > Thank you for reviewing the patch. Pushed. > > nitpick: I think this one needs a pgindent run. Thank you for pointing it out. I forgot to check with pgindent. I've pushed

Re: Fix memory counter update in reorderbuffer

2024-08-26 Thread Nathan Bossart
On Mon, Aug 26, 2024 at 11:25:53AM -0700, Masahiko Sawada wrote: > Thank you for reviewing the patch. Pushed. nitpick: I think this one needs a pgindent run. -- nathan

Re: Fix memory counter update in reorderbuffer

2024-08-26 Thread Masahiko Sawada
On Sun, Aug 25, 2024 at 9:29 PM Amit Kapila wrote: > > On Fri, Aug 23, 2024 at 3:44 PM Masahiko Sawada wrote: > > > > On Tue, Aug 20, 2024 at 9:29 PM Amit Kapila wrote: > > > > > > > I've updated the updated patch with regression tests. > > > > LGTM. Thank you for reviewing the patch. Pushed.

Re: Fix memory counter update in reorderbuffer

2024-08-25 Thread Amit Kapila
On Fri, Aug 23, 2024 at 3:44 PM Masahiko Sawada wrote: > > On Tue, Aug 20, 2024 at 9:29 PM Amit Kapila wrote: > > > > I've updated the updated patch with regression tests. > LGTM. -- With Regards, Amit Kapila.

Re: Fix memory counter update in reorderbuffer

2024-08-23 Thread Masahiko Sawada
On Tue, Aug 20, 2024 at 9:29 PM Amit Kapila wrote: > > On Tue, Aug 20, 2024 at 5:55 PM Masahiko Sawada wrote: > > > > On Fri, Aug 16, 2024 at 12:22 AM Shlok Kyal > > wrote: > > > > > > > Thank you for testing the patch! > > > > I'm slightly hesitant to add a test under src/test/subscription sin

Re: Fix memory counter update in reorderbuffer

2024-08-20 Thread Amit Kapila
On Tue, Aug 20, 2024 at 5:55 PM Masahiko Sawada wrote: > > On Fri, Aug 16, 2024 at 12:22 AM Shlok Kyal wrote: > > > > Thank you for testing the patch! > > I'm slightly hesitant to add a test under src/test/subscription since > it's a bug in ReorderBuffer and not specific to logical replication. >

Re: Fix memory counter update in reorderbuffer

2024-08-20 Thread Masahiko Sawada
Hi, On Fri, Aug 16, 2024 at 12:22 AM Shlok Kyal wrote: > > On Wed, 7 Aug 2024 at 11:48, Amit Kapila wrote: > > > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada > > wrote: > > > > > > On Tue, Aug 6, 2024 at 1:12 PM Amit Kapila > > > wrote: > > > > > > > > On Sat, Aug 3, 2024 at 1:21 AM Masa

Re: Fix memory counter update in reorderbuffer

2024-08-16 Thread Shlok Kyal
On Wed, 7 Aug 2024 at 11:48, Amit Kapila wrote: > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada wrote: > > > > On Tue, Aug 6, 2024 at 1:12 PM Amit Kapila wrote: > > > > > > On Sat, Aug 3, 2024 at 1:21 AM Masahiko Sawada > > > wrote: > > > > > > > > I found a bug in the memory counter update

Re: Fix memory counter update in reorderbuffer

2024-08-11 Thread Masahiko Sawada
On Sat, Aug 10, 2024 at 5:48 AM Masahiko Sawada wrote: > > On Fri, Aug 9, 2024 at 3:30 PM Amit Kapila wrote: > > > > On Thu, Aug 8, 2024 at 9:43 PM Masahiko Sawada > > wrote: > > > > > > On Wed, Aug 7, 2024 at 3:17 PM Amit Kapila > > > wrote: > > > > > > > > On Wed, Aug 7, 2024 at 7:42 AM Mas

Re: Fix memory counter update in reorderbuffer

2024-08-09 Thread Masahiko Sawada
On Fri, Aug 9, 2024 at 3:30 PM Amit Kapila wrote: > > On Thu, Aug 8, 2024 at 9:43 PM Masahiko Sawada wrote: > > > > On Wed, Aug 7, 2024 at 3:17 PM Amit Kapila wrote: > > > > > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada > > > wrote: > > > > > > > > > > > > > > BTW, commit 5bec1d6bc5e also

Re: Fix memory counter update in reorderbuffer

2024-08-08 Thread Amit Kapila
On Thu, Aug 8, 2024 at 9:43 PM Masahiko Sawada wrote: > > On Wed, Aug 7, 2024 at 3:17 PM Amit Kapila wrote: > > > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada > > wrote: > > > > > > > > > > BTW, commit 5bec1d6bc5e also introduced > > > > ReorderBufferChangeMemoryUpdate() in ReorderBufferTru

Re: Fix memory counter update in reorderbuffer

2024-08-08 Thread Masahiko Sawada
On Wed, Aug 7, 2024 at 3:17 PM Amit Kapila wrote: > > On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada wrote: > > > > On Tue, Aug 6, 2024 at 1:12 PM Amit Kapila wrote: > > > > > > On Sat, Aug 3, 2024 at 1:21 AM Masahiko Sawada > > > wrote: > > > > > > > > I found a bug in the memory counter upda

Re: Fix memory counter update in reorderbuffer

2024-08-06 Thread Amit Kapila
On Wed, Aug 7, 2024 at 7:42 AM Masahiko Sawada wrote: > > On Tue, Aug 6, 2024 at 1:12 PM Amit Kapila wrote: > > > > On Sat, Aug 3, 2024 at 1:21 AM Masahiko Sawada > > wrote: > > > > > > I found a bug in the memory counter update in reorderbuffer. It was > > > introduced by commit 5bec1d6bc5e, s

Re: Fix memory counter update in reorderbuffer

2024-08-06 Thread Masahiko Sawada
On Tue, Aug 6, 2024 at 1:12 PM Amit Kapila wrote: > > On Sat, Aug 3, 2024 at 1:21 AM Masahiko Sawada wrote: > > > > I found a bug in the memory counter update in reorderbuffer. It was > > introduced by commit 5bec1d6bc5e, so pg17 and master are affected. > > > > In ReorderBufferCleanupTXN() we ze

Re: Fix memory counter update in reorderbuffer

2024-08-05 Thread Amit Kapila
On Sat, Aug 3, 2024 at 1:21 AM Masahiko Sawada wrote: > > I found a bug in the memory counter update in reorderbuffer. It was > introduced by commit 5bec1d6bc5e, so pg17 and master are affected. > > In ReorderBufferCleanupTXN() we zero the transaction size and then > free the transaction entry as