Re: Fix hints on CREATE PROCEDURE errors

2018-08-18 Thread Jonathan S. Katz
> On Aug 18, 2018, at 4:22 PM, Peter Eisentraut > wrote: > > This has been committed. Thanks - I’ve moved it off of the open items list. Jonathan signature.asc Description: Message signed with OpenPGP

Re: Fix hints on CREATE PROCEDURE errors

2018-08-18 Thread Peter Eisentraut
This has been committed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Fix hints on CREATE PROCEDURE errors

2018-08-18 Thread Jonathan S. Katz
> On Aug 8, 2018, at 3:18 PM, Tom Lane wrote: > > Peter Eisentraut writes: >> Yes, the hint should be changed. But I also think the error message >> should be changed to be more appropriate to the procedure situation >> (where is the return type?). Attached patch does both. Unlike your >> pa

Re: Fix hints on CREATE PROCEDURE errors

2018-08-08 Thread Tom Lane
Peter Eisentraut writes: > Yes, the hint should be changed. But I also think the error message > should be changed to be more appropriate to the procedure situation > (where is the return type?). Attached patch does both. Unlike your > patch, I kept the "DROP FUNCTION" message for the function

Re: Fix hints on CREATE PROCEDURE errors

2018-08-08 Thread Peter Eisentraut
On 06/08/2018 20:32, Jeremy Evans wrote: > The current code's hint is misleading for procedures: > > CREATE OR REPLACE PROCEDURE a(in int) > LANGUAGE SQL > AS $$ > SELECT NULL; > $$; > # CREATE PROCEDURE > > CREATE OR REPLACE PROCEDURE a(inout int) > LANGUAGE SQL > AS $$ > SELECT NULL; > $$; > #

Re: Fix hints on CREATE PROCEDURE errors

2018-08-07 Thread Amit Langote
Hi. On 2018/08/07 3:32, Jeremy Evans wrote: > When testing out CREATE PROCEDURE with 11 beta 2, I noticed, the hints > in the errors reference DROP FUNCTION, which doesn't work for > procedures. Good catch. > DROP ROUTINE works for both functions and procedures, so > this patch should work for b