Hi,
I've pushed (and backpatched) all the fixes posted to this thread. I
believe that covers all the incremental sort fixes, so I've marked [1]
as committed.
[1] https://commitfest.postgresql.org/31/2754/
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Post
Hi,
I reviewed the patch series, tweaked a couple comments, added commit
messages etc. Barring objections, I'll push this in a couple days.
One thing that annoys me is that it breaks ABI because it adds two new
parameters to find_em_expr_usable_for_sorting_rel, but I don't think we
can get around
On Sun, Nov 29, 2020 at 4:20 PM Tomas Vondra
wrote:
>
> On 11/29/20 3:26 PM, James Coleman wrote:
> > On Mon, Nov 23, 2020 at 8:35 AM James Coleman wrote:
> >>
> >> On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra
> >> wrote:
> >>> ...
> >>> Thanks for the patches, I'll take a closer look next week.
On 11/29/20 3:26 PM, James Coleman wrote:
> On Mon, Nov 23, 2020 at 8:35 AM James Coleman wrote:
>>
>> On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra
>> wrote:
>>> ...
>>> Thanks for the patches, I'll take a closer look next week. The 0002
>>> patch is clearly something we need to backpatch, not su
On Mon, Nov 23, 2020 at 8:35 AM James Coleman wrote:
>
> On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra
> wrote:
> > ...
> > Thanks for the patches, I'll take a closer look next week. The 0002
> > patch is clearly something we need to backpatch, not sure about 0001 as
> > it essentially enables new
On Sun, Nov 22, 2020 at 4:59 PM Tomas Vondra
wrote:
>
> On 11/21/20 2:55 AM, James Coleman wrote:
> > Over on the -bugs list we had a report [1] of a seg fault with
> > incremental sort. The short of the investigation there was that a
> > subplan wasn't being serialized since it wasn't parallel sa
On 11/21/20 2:55 AM, James Coleman wrote:
> Over on the -bugs list we had a report [1] of a seg fault with
> incremental sort. The short of the investigation there was that a
> subplan wasn't being serialized since it wasn't parallel safe, and
> that attempting to initialize that subplan resulted i
