Re: Fix comments of heap_prune_chain()

2021-07-13 Thread Masahiro Ikeda
On 2021/07/13 10:22, Kyotaro Horiguchi wrote: > (This is out of topic) > > At Mon, 12 Jul 2021 20:17:55 -0400, Alvaro Herrera > wrote in >> Oh, apologies, I didn't realize there was an attachment. That seems >> specific enough :-) >> >> In my defense, the archives don't show the attachment

Re: Fix comments of heap_prune_chain()

2021-07-13 Thread Masahiro Ikeda
On 2021/07/13 5:57, Matthias van de Meent wrote: > > > On Mon, 12 Jul 2021 at 13:14, > wrote: >> >> Hi, >> >> While I’m reading source codes related to vacuum, I found comments which >> don’t seem to fit the reality. I think the commit[1] just forgot to fix the

Re: Fix comments of heap_prune_chain()

2021-07-12 Thread Kyotaro Horiguchi
(This is out of topic) At Mon, 12 Jul 2021 20:17:55 -0400, Alvaro Herrera wrote in > Oh, apologies, I didn't realize there was an attachment. That seems > specific enough :-) > > In my defense, the archives don't show the attachment either: > https://www.postgresql.org/message-id/5CB29811-2B1

Re: Fix comments of heap_prune_chain()

2021-07-12 Thread Alvaro Herrera
On 2021-Jul-12, Alvaro Herrera wrote: > On 2021-Jul-12, ikeda...@oss.nttdata.com wrote: > > > While I’m reading source codes related to vacuum, I found comments which > > don’t seem to fit the reality. I think the commit[1] just forgot to fix > > them. > > What do you think? > > > > [1] > > ht

Re: Fix comments of heap_prune_chain()

2021-07-12 Thread Matthias van de Meent
On Mon, 12 Jul 2021 at 13:14, wrote: > > Hi, > > While I’m reading source codes related to vacuum, I found comments which > don’t seem to fit the reality. I think the commit[1] just forgot to fix them. > What do you think? Hmm, yes, those are indeed some leftovers. Some comments on the suggested

Re: Fix comments of heap_prune_chain()

2021-07-12 Thread Alvaro Herrera
On 2021-Jul-12, ikeda...@oss.nttdata.com wrote: > While I’m reading source codes related to vacuum, I found comments which > don’t seem to fit the reality. I think the commit[1] just forgot to fix them. > What do you think? > > [1] > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h