Re: Fix comments atop pg_get_replication_slots

2022-11-22 Thread Amit Kapila
On Mon, Nov 21, 2022 at 1:22 PM sirisha chamarthi wrote: > > Looks good to me. Attached a patch for the same. > Pushed. -- With Regards, Amit Kapila.

Re: Fix comments atop pg_get_replication_slots

2022-11-20 Thread sirisha chamarthi
Amit, thanks for looking into this! On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila wrote: > On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi > wrote: > > > > Hi Hackers, > > > > The comments atop seem to indicate that it is only showing active > replication slots. The comment is ambiguous as it

Re: Fix comments atop pg_get_replication_slots

2022-11-20 Thread Amit Kapila
On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi wrote: > > Hi Hackers, > > The comments atop seem to indicate that it is only showing active replication > slots. The comment is ambiguous as it also shows all the slots including lost > and inactive slots. Attached a small patch to fix it. > I