Re: Fix bug in VACUUM and ANALYZE docs

2023-09-24 Thread Michael Paquier
On Sun, Sep 24, 2023 at 06:30:32PM -0500, Karl O. Pinc wrote: > I signed up to review, but I think that perhaps commitfest > https://commitfest.postgresql.org/45/4574/ > needs marking as applied and done? Indeed. I did not notice that there was a CF entry for this one. Closed it now. -- Michael

Re: Fix bug in VACUUM and ANALYZE docs

2023-09-24 Thread Karl O. Pinc
On Wed, 20 Sep 2023 13:39:02 +0900 Michael Paquier wrote: > On Wed, Sep 20, 2023 at 09:43:15AM +0900, Shinya Kato wrote: > > You're right. It looks good to me. > > Right, it feels like there has been a lot of copy-paste in this area > of the docs. Applied down to 16. I signed up to review,

Re: Fix bug in VACUUM and ANALYZE docs

2023-09-19 Thread Michael Paquier
On Wed, Sep 20, 2023 at 09:43:15AM +0900, Shinya Kato wrote: > Thanks for the patch. > You're right. It looks good to me. Right, it feels like there has been a lot of copy-paste in this area of the docs. Applied down to 16. -- Michael signature.asc Description: PGP signature

Re: Fix bug in VACUUM and ANALYZE docs

2023-09-19 Thread Shinya Kato
On 2023-09-19 17:59, Ryoga Yoshida wrote: Hi, Issue1: VACUUM and ANALYZE docs explain that the parameter of BUFFER_USAGE_LIMIT is optional as follows. But this is not true. The argument, size, is required for BUFFER_USAGE_LIMIT. So the docs should be fixed this issue. BUFFER_USAGE_LIMIT [ size ]